(web-components) Added support for Segoe UI Variable font with variant configurations #22079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 65a8c54:
|
📊 Bundle size report🤖 This report was generated against 8f44d809d2d56a5ffe274fbb479f38fafec1eb7a |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8f44d809d2d56a5ffe274fbb479f38fafec1eb7a (build) |
EisenbergEffect
approved these changes
Mar 14, 2022
robarbms
approved these changes
Mar 15, 2022
bheston
force-pushed
the
type-ramp-font-by-size
branch
from
41875a4
to
869dd08
Compare
|
In testing, there are some extraneous font attributes that could be removed, but I'll leave that for a cleanup pass. All components correctly use the token values for all visible type I saw in the samples. |
chrisdholt
reviewed
Mar 31, 2022
chrisdholt
reviewed
Mar 31, 2022
chrisdholt
reviewed
Mar 31, 2022
bheston
force-pushed
the
type-ramp-font-by-size
branch
from
869dd08
to
0ab974f
Compare
chrisdholt
approved these changes
May 5, 2022
Added type ramp helpes to conveniently and consistently apply all necessary font attributes.
bheston
force-pushed
the
type-ramp-font-by-size
branch
from
0ab974f
to
6792d2a
Compare
bheston
force-pushed
the
type-ramp-font-by-size
branch
from
6792d2a
to
65a8c54
Compare
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…t configurations (microsoft#22079) Added support for Segoe UI Variable font with variant configurations Added type ramp helpers to conveniently and consistently apply all necessary font attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Segoe UI Variable font with variant configurations
Added type ramp helpers to conveniently and consistently apply all necessary font attributes
Will remove font weight slider from Storybook page before merge.
Current Behavior
Uses "Segoe UI" non-variable font
New Behavior
Uses "Segoe UI Variable" by default if registered for the app/page.
Includes variable font variant settings based on font size.
Edge
Firefox
Safari
Related Issue(s)
Fixes #22078 #21524