-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package dependencies in web-components #21895
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d9458da:
|
"@microsoft/fast-element": "^1.6.0", | ||
"@microsoft/fast-foundation": "^2.32.0", | ||
"@microsoft/fast-web-utilities": "^5.0.0", | ||
"@microsoft/fast-colors": "^5.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can stay - ideally it resolves either way, nothing is breaking here but this would trigger a cascade for dependents, yes?
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1940164411685db2967f8452406bb703b94ec266 (build) |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
DatepickerMinimalPerf.default | 5219 | 4714 | 1.11:1 |
SegmentMinimalPerf.default | 320 | 291 | 1.1:1 |
ChatWithPopoverPerf.default | 359 | 330 | 1.09:1 |
IconMinimalPerf.default | 538 | 495 | 1.09:1 |
ListWith60ListItems.default | 601 | 555 | 1.08:1 |
TreeWith60ListItems.default | 179 | 166 | 1.08:1 |
LabelMinimalPerf.default | 347 | 331 | 1.05:1 |
TextAreaMinimalPerf.default | 440 | 419 | 1.05:1 |
FlexMinimalPerf.default | 248 | 239 | 1.04:1 |
ItemLayoutMinimalPerf.default | 1049 | 1010 | 1.04:1 |
ListCommonPerf.default | 565 | 544 | 1.04:1 |
ReactionMinimalPerf.default | 331 | 318 | 1.04:1 |
TableMinimalPerf.default | 360 | 346 | 1.04:1 |
ButtonSlotsPerf.default | 470 | 455 | 1.03:1 |
CarouselMinimalPerf.default | 417 | 405 | 1.03:1 |
ChatDuplicateMessagesPerf.default | 266 | 259 | 1.03:1 |
DividerMinimalPerf.default | 312 | 304 | 1.03:1 |
RadioGroupMinimalPerf.default | 392 | 382 | 1.03:1 |
TableManyItemsPerf.default | 1636 | 1595 | 1.03:1 |
ToolbarMinimalPerf.default | 832 | 805 | 1.03:1 |
AttachmentSlotsPerf.default | 937 | 921 | 1.02:1 |
ChatMinimalPerf.default | 660 | 646 | 1.02:1 |
LayoutMinimalPerf.default | 329 | 323 | 1.02:1 |
ListMinimalPerf.default | 452 | 444 | 1.02:1 |
ListNestedPerf.default | 498 | 488 | 1.02:1 |
LoaderMinimalPerf.default | 600 | 588 | 1.02:1 |
PortalMinimalPerf.default | 158 | 155 | 1.02:1 |
RefMinimalPerf.default | 214 | 209 | 1.02:1 |
SliderMinimalPerf.default | 1416 | 1395 | 1.02:1 |
AnimationMinimalPerf.default | 469 | 464 | 1.01:1 |
AttachmentMinimalPerf.default | 136 | 135 | 1.01:1 |
DialogMinimalPerf.default | 656 | 649 | 1.01:1 |
DropdownMinimalPerf.default | 2564 | 2540 | 1.01:1 |
EmbedMinimalPerf.default | 3501 | 3467 | 1.01:1 |
FormMinimalPerf.default | 359 | 356 | 1.01:1 |
GridMinimalPerf.default | 302 | 299 | 1.01:1 |
HeaderMinimalPerf.default | 316 | 314 | 1.01:1 |
HeaderSlotsPerf.default | 661 | 652 | 1.01:1 |
ImageMinimalPerf.default | 324 | 321 | 1.01:1 |
MenuMinimalPerf.default | 732 | 727 | 1.01:1 |
MenuButtonMinimalPerf.default | 1435 | 1416 | 1.01:1 |
ProviderMinimalPerf.default | 978 | 972 | 1.01:1 |
SplitButtonMinimalPerf.default | 3723 | 3684 | 1.01:1 |
VideoMinimalPerf.default | 531 | 528 | 1.01:1 |
AvatarMinimalPerf.default | 173 | 173 | 1:1 |
ButtonOverridesMissPerf.default | 1426 | 1424 | 1:1 |
CardMinimalPerf.default | 479 | 480 | 1:1 |
CheckboxMinimalPerf.default | 2308 | 2303 | 1:1 |
DropdownManyItemsPerf.default | 579 | 580 | 1:1 |
InputMinimalPerf.default | 1097 | 1100 | 1:1 |
ProviderMergeThemesPerf.default | 1471 | 1465 | 1:1 |
SkeletonMinimalPerf.default | 304 | 303 | 1:1 |
CustomToolbarPrototype.default | 3633 | 3627 | 1:1 |
TooltipMinimalPerf.default | 905 | 907 | 1:1 |
TreeMinimalPerf.default | 703 | 701 | 1:1 |
BoxMinimalPerf.default | 299 | 301 | 0.99:1 |
RosterPerf.default | 1001 | 1012 | 0.99:1 |
PopupMinimalPerf.default | 518 | 524 | 0.99:1 |
ButtonMinimalPerf.default | 152 | 155 | 0.98:1 |
StatusMinimalPerf.default | 589 | 613 | 0.96:1 |
TextMinimalPerf.default | 302 | 315 | 0.96:1 |
AlertMinimalPerf.default | 226 | 238 | 0.95:1 |
AccordionMinimalPerf.default | 130 | 142 | 0.92:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 788 | 777 | 5000 | |
BaseButton | mount | 806 | 802 | 5000 | |
Breadcrumb | mount | 2185 | 2182 | 1000 | |
ButtonNext | mount | 456 | 458 | 5000 | |
Checkbox | mount | 1300 | 1272 | 5000 | |
CheckboxBase | mount | 1113 | 1097 | 5000 | |
ChoiceGroup | mount | 3948 | 4002 | 5000 | |
ComboBox | mount | 789 | 783 | 1000 | |
CommandBar | mount | 8531 | 8577 | 1000 | |
ContextualMenu | mount | 6931 | 6996 | 1000 | |
DefaultButton | mount | 972 | 982 | 5000 | |
DetailsRow | mount | 3021 | 3021 | 5000 | |
DetailsRowFast | mount | 3009 | 3036 | 5000 | |
DetailsRowNoStyles | mount | 2876 | 2867 | 5000 | |
Dialog | mount | 1856 | 1885 | 1000 | |
DocumentCardTitle | mount | 174 | 151 | 1000 | |
Dropdown | mount | 2743 | 2730 | 5000 | |
FluentProviderNext | mount | 1613 | 1644 | 5000 | |
FluentProviderWithTheme | mount | 151 | 131 | 10 | |
FluentProviderWithTheme | virtual-rerender | 107 | 96 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 175 | 173 | 10 | |
FocusTrapZone | mount | 1548 | 1523 | 5000 | |
FocusZone | mount | 1538 | 1545 | 5000 | |
IconButton | mount | 1393 | 1418 | 5000 | |
Label | mount | 359 | 343 | 5000 | |
Layer | mount | 2597 | 2584 | 5000 | |
Link | mount | 480 | 465 | 5000 | |
MakeStyles | mount | 1603 | 1626 | 50000 | |
MenuButton | mount | 1243 | 1240 | 5000 | |
MessageBar | mount | 1788 | 1762 | 5000 | |
Nav | mount | 2637 | 2663 | 1000 | |
OverflowSet | mount | 1037 | 1026 | 5000 | |
Panel | mount | 1793 | 1812 | 1000 | |
Persona | mount | 758 | 736 | 1000 | |
Pivot | mount | 1131 | 1160 | 1000 | |
PrimaryButton | mount | 1101 | 1119 | 5000 | |
Rating | mount | 6697 | 6723 | 5000 | |
SearchBox | mount | 1172 | 1155 | 5000 | |
Shimmer | mount | 2240 | 2293 | 5000 | |
Slider | mount | 1738 | 1738 | 5000 | |
SpinButton | mount | 3953 | 3929 | 5000 | |
Spinner | mount | 425 | 430 | 5000 | |
SplitButton | mount | 2473 | 2444 | 5000 | |
Stack | mount | 515 | 515 | 5000 | |
StackWithIntrinsicChildren | mount | 1851 | 1899 | 5000 | |
StackWithTextChildren | mount | 4688 | 4656 | 5000 | |
SwatchColorPicker | mount | 8923 | 9004 | 5000 | |
TagPicker | mount | 1990 | 2046 | 5000 | |
TeachingBubble | mount | 10592 | 10544 | 5000 | |
Text | mount | 428 | 434 | 5000 | |
TextField | mount | 1173 | 1160 | 5000 | |
ThemeProvider | mount | 961 | 976 | 5000 | |
ThemeProvider | virtual-rerender | 598 | 600 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1418 | 1428 | 5000 | |
Toggle | mount | 749 | 735 | 5000 | |
buttonNative | mount | 133 | 125 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
You can ignore the one failed check, it's a pipeline under development that's not supposed to be running against PRs (I'll talk to the owner about that). |
Current Behavior
The package dependencies in
@fluentui/web-components
are out of date. Additionally, the<fluent-combobox>
component is missing thedelegatesFocus
configuration.New Behavior
@microsoft/fast-element
to^1.7.0
@microsoft/fast-foundation
to^2.33.6
@microsoft/fast-colors
to^5.1.5
@microsoft/fast-web-utilities
to^5.1.0
delegatesFocus
property configuration for<fluent-combobox>