Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components) aligned "plus 2" type ramp line height size #21698

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

bheston
Copy link
Contributor

@bheston bheston commented Feb 10, 2022

Current Behavior

"Plus 2"" type ramp line height size was not aligned with Fluent Design.

New Behavior

Adjusts the line height by reducing 2px.

@bheston bheston changed the title Aligned "plus 2" type ramp line height size (web-components) aligned "plus 2" type ramp line height size Feb 10, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06a3daa:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 10, 2022

📊 Bundle size report

🤖 This report was generated against ac791cdd030b81a10df2a2ab76ad11b69fe06740

@size-auditor
Copy link

size-auditor bot commented Feb 10, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ac791cdd030b81a10df2a2ab76ad11b69fe06740 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 10, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 877 919 5000
BaseButton mount 932 923 5000
Breadcrumb mount 2796 2796 1000
ButtonNext mount 522 499 5000
Checkbox mount 1633 1545 5000
CheckboxBase mount 1332 1340 5000
ChoiceGroup mount 4903 4912 5000
ComboBox mount 1008 994 1000
CommandBar mount 10624 10536 1000
ContextualMenu mount 8838 8726 1000
DefaultButton mount 1178 1192 5000
DetailsRow mount 3767 3792 5000
DetailsRowFast mount 3818 3835 5000
DetailsRowNoStyles mount 3651 3569 5000
Dialog mount 2302 2267 1000
DocumentCardTitle mount 182 176 1000
Dropdown mount 3323 3291 5000
FluentProviderNext mount 1953 1897 5000
FluentProviderWithTheme mount 172 153 10
FluentProviderWithTheme virtual-rerender 106 107 10
FluentProviderWithTheme virtual-rerender-with-unmount 196 196 10
FocusTrapZone mount 1925 1864 5000
FocusZone mount 1855 1844 5000
IconButton mount 1746 1801 5000
Label mount 395 379 5000
Layer mount 2990 3047 5000
Link mount 515 514 5000
MakeStyles mount 1701 1702 50000
MenuButton mount 1532 1497 5000
MessageBar mount 2116 2180 5000
Nav mount 3301 3380 1000
OverflowSet mount 1160 1171 5000
Panel mount 2148 2219 1000
Persona mount 905 865 1000
Pivot mount 1495 1445 1000
PrimaryButton mount 1346 1352 5000
Rating mount 7774 7830 5000
SearchBox mount 1372 1390 5000
Shimmer mount 2614 2652 5000
Slider mount 2061 2046 5000
SpinButton mount 5124 5137 5000
Spinner mount 465 473 5000
SplitButton mount 3251 3207 5000
Stack mount 557 564 5000
StackWithIntrinsicChildren mount 2293 2298 5000
StackWithTextChildren mount 5323 5315 5000
SwatchColorPicker mount 11620 11606 5000
TagPicker mount 2640 2643 5000
TeachingBubble mount 13104 13242 5000
Text mount 464 466 5000
TextField mount 1401 1416 5000
ThemeProvider mount 1256 1212 5000
ThemeProvider virtual-rerender 659 653 5000
ThemeProvider virtual-rerender-with-unmount 1957 1956 5000
Toggle mount 849 849 5000
buttonNative mount 154 152 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 220 192 1.15:1
ButtonMinimalPerf.default 188 164 1.15:1
ChatDuplicateMessagesPerf.default 332 293 1.13:1
FormMinimalPerf.default 428 379 1.13:1
TreeWith60ListItems.default 194 178 1.09:1
GridMinimalPerf.default 353 330 1.07:1
TextAreaMinimalPerf.default 515 482 1.07:1
AnimationMinimalPerf.default 569 535 1.06:1
LayoutMinimalPerf.default 379 356 1.06:1
AttachmentMinimalPerf.default 166 158 1.05:1
DividerMinimalPerf.default 379 364 1.04:1
LoaderMinimalPerf.default 702 678 1.04:1
RefMinimalPerf.default 251 241 1.04:1
IconMinimalPerf.default 624 602 1.04:1
TableMinimalPerf.default 421 404 1.04:1
TreeMinimalPerf.default 823 795 1.04:1
CardMinimalPerf.default 569 555 1.03:1
ImageMinimalPerf.default 387 377 1.03:1
ListMinimalPerf.default 537 522 1.03:1
PopupMinimalPerf.default 637 618 1.03:1
PortalMinimalPerf.default 182 177 1.03:1
ReactionMinimalPerf.default 396 386 1.03:1
SkeletonMinimalPerf.default 358 348 1.03:1
BoxMinimalPerf.default 353 346 1.02:1
CarouselMinimalPerf.default 494 485 1.02:1
CheckboxMinimalPerf.default 2731 2669 1.02:1
DatepickerMinimalPerf.default 5833 5736 1.02:1
LabelMinimalPerf.default 404 398 1.02:1
MenuMinimalPerf.default 834 820 1.02:1
ProviderMinimalPerf.default 1132 1109 1.02:1
StatusMinimalPerf.default 704 692 1.02:1
TableManyItemsPerf.default 1926 1886 1.02:1
AttachmentSlotsPerf.default 1090 1078 1.01:1
ChatMinimalPerf.default 756 748 1.01:1
ChatWithPopoverPerf.default 394 391 1.01:1
DropdownManyItemsPerf.default 695 685 1.01:1
DropdownMinimalPerf.default 2999 2980 1.01:1
EmbedMinimalPerf.default 4180 4158 1.01:1
ItemLayoutMinimalPerf.default 1190 1181 1.01:1
ListCommonPerf.default 639 631 1.01:1
ListNestedPerf.default 547 544 1.01:1
ListWith60ListItems.default 656 651 1.01:1
RadioGroupMinimalPerf.default 449 443 1.01:1
SliderMinimalPerf.default 1694 1677 1.01:1
SplitButtonMinimalPerf.default 4324 4283 1.01:1
TextMinimalPerf.default 349 345 1.01:1
TooltipMinimalPerf.default 1036 1026 1.01:1
AlertMinimalPerf.default 278 280 0.99:1
ButtonOverridesMissPerf.default 1696 1717 0.99:1
ButtonSlotsPerf.default 554 558 0.99:1
DialogMinimalPerf.default 763 772 0.99:1
FlexMinimalPerf.default 292 294 0.99:1
HeaderMinimalPerf.default 364 369 0.99:1
HeaderSlotsPerf.default 764 770 0.99:1
SegmentMinimalPerf.default 353 356 0.99:1
CustomToolbarPrototype.default 4160 4199 0.99:1
InputMinimalPerf.default 1278 1301 0.98:1
ProviderMergeThemesPerf.default 1723 1759 0.98:1
ToolbarMinimalPerf.default 926 947 0.98:1
VideoMinimalPerf.default 612 627 0.98:1
AccordionMinimalPerf.default 152 156 0.97:1
MenuButtonMinimalPerf.default 1615 1662 0.97:1
RosterPerf.default 1156 1186 0.97:1

@ling1726 ling1726 closed this Feb 17, 2022
@ling1726 ling1726 reopened this Feb 17, 2022
@bheston bheston merged commit b8bea1a into microsoft:master Feb 17, 2022
@bheston bheston deleted the align-type-ramp branch February 17, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants