Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web components) fix cursor issue text field #20445

Conversation

chrisdholt
Copy link
Member

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 2, 2021

📊 Bundle size report

🤖 This report was generated against 42315bf9bdc7810cd0fba0cc77ecb975d95ea86e

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed3f604:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 2, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 42315bf9bdc7810cd0fba0cc77ecb975d95ea86e (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 2, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1079 700 5000
BaseButton mount 732 775 5000
Breadcrumb mount 2233 2027 1000
ButtonNext mount 453 380 5000
Checkbox mount 1281 1304 5000
CheckboxBase mount 1104 1122 5000
ChoiceGroup mount 3925 3806 5000
ComboBox mount 852 859 1000
CommandBar mount 8627 8363 1000
ContextualMenu mount 5463 5516 1000
DefaultButton mount 895 958 5000
DetailsRow mount 3180 3050 5000
DetailsRowFast mount 3027 2961 5000
DetailsRowNoStyles mount 2984 3116 5000
Dialog mount 2235 2136 1000
DocumentCardTitle mount 161 148 1000
Dropdown mount 2747 2636 5000
FluentProviderNext mount 2876 2883 5000
FluentProviderWithTheme mount 186 194 10
FluentProviderWithTheme virtual-rerender 93 93 10
FluentProviderWithTheme virtual-rerender-with-unmount 209 202 10
FocusTrapZone mount 1495 1497 5000
FocusZone mount 1536 1391 5000
IconButton mount 1484 1382 5000
Label mount 290 274 5000
Layer mount 2536 2532 5000
Link mount 427 403 5000
MakeStyles mount 1541 1543 50000
MenuButton mount 1229 1128 5000
MessageBar mount 1599 1647 5000
Nav mount 2875 2537 1000
OverflowSet mount 963 933 5000
Panel mount 2071 2057 1000
Persona mount 715 737 1000
Pivot mount 1103 1113 1000
PrimaryButton mount 1022 1102 5000
Rating mount 6298 6544 5000
SearchBox mount 1115 1171 5000
Shimmer mount 2201 2028 5000
Slider mount 1545 1706 5000
SpinButton mount 4303 4279 5000
Spinner mount 384 346 5000
SplitButton mount 2749 2448 5000
Stack mount 439 433 5000
StackWithIntrinsicChildren mount 1411 1450 5000
StackWithTextChildren mount 3813 3950 5000
SwatchColorPicker mount 9128 8907 5000
TagPicker mount 2267 2226 5000
TeachingBubble mount 10884 11162 5000
Text mount 326 375 5000
TextField mount 1212 1200 5000
ThemeProvider mount 1019 995 5000
ThemeProvider virtual-rerender 528 524 5000
ThemeProvider virtual-rerender-with-unmount 1566 1589 5000
Toggle mount 655 716 5000
buttonNative mount 108 124 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderSlotsPerf.default 656 581 1.13:1
ButtonMinimalPerf.default 162 145 1.12:1
FormMinimalPerf.default 319 286 1.12:1
ListWith60ListItems.default 533 474 1.12:1
ChatWithPopoverPerf.default 339 305 1.11:1
GridMinimalPerf.default 301 272 1.11:1
LoaderMinimalPerf.default 609 568 1.07:1
PopupMinimalPerf.default 522 489 1.07:1
ReactionMinimalPerf.default 345 321 1.07:1
TableMinimalPerf.default 365 342 1.07:1
TreeMinimalPerf.default 691 648 1.07:1
AttachmentSlotsPerf.default 865 816 1.06:1
ItemLayoutMinimalPerf.default 1008 951 1.06:1
RosterPerf.default 1011 955 1.06:1
TooltipMinimalPerf.default 906 857 1.06:1
HeaderMinimalPerf.default 318 304 1.05:1
ProviderMergeThemesPerf.default 1420 1357 1.05:1
TableManyItemsPerf.default 1507 1431 1.05:1
VideoMinimalPerf.default 527 501 1.05:1
AttachmentMinimalPerf.default 147 141 1.04:1
AvatarMinimalPerf.default 180 173 1.04:1
CardMinimalPerf.default 463 445 1.04:1
FlexMinimalPerf.default 264 255 1.04:1
ListMinimalPerf.default 445 428 1.04:1
ListNestedPerf.default 483 463 1.04:1
AnimationMinimalPerf.default 363 354 1.03:1
StatusMinimalPerf.default 592 575 1.03:1
ChatDuplicateMessagesPerf.default 272 266 1.02:1
DatepickerMinimalPerf.default 4772 4682 1.02:1
DropdownManyItemsPerf.default 578 565 1.02:1
LabelMinimalPerf.default 336 331 1.02:1
IconMinimalPerf.default 466 456 1.02:1
AccordionMinimalPerf.default 128 127 1.01:1
AlertMinimalPerf.default 230 228 1.01:1
ChatMinimalPerf.default 563 563 1:1
EmbedMinimalPerf.default 3580 3586 1:1
InputMinimalPerf.default 1102 1106 1:1
LayoutMinimalPerf.default 305 306 1:1
MenuMinimalPerf.default 675 675 1:1
ToolbarMinimalPerf.default 776 773 1:1
ButtonOverridesMissPerf.default 1501 1511 0.99:1
CarouselMinimalPerf.default 357 360 0.99:1
PortalMinimalPerf.default 142 143 0.99:1
SegmentMinimalPerf.default 293 295 0.99:1
SkeletonMinimalPerf.default 290 293 0.99:1
DialogMinimalPerf.default 617 628 0.98:1
DropdownMinimalPerf.default 2625 2691 0.98:1
SplitButtonMinimalPerf.default 3439 3504 0.98:1
CheckboxMinimalPerf.default 2227 2304 0.97:1
ListCommonPerf.default 502 520 0.97:1
SliderMinimalPerf.default 1375 1417 0.97:1
CustomToolbarPrototype.default 3493 3650 0.96:1
TreeWith60ListItems.default 159 166 0.96:1
MenuButtonMinimalPerf.default 1352 1420 0.95:1
ProviderMinimalPerf.default 938 989 0.95:1
TextAreaMinimalPerf.default 403 427 0.94:1
DividerMinimalPerf.default 277 308 0.9:1
RefMinimalPerf.default 189 212 0.89:1
TextMinimalPerf.default 266 298 0.89:1
ButtonSlotsPerf.default 412 471 0.87:1
RadioGroupMinimalPerf.default 328 383 0.86:1
ImageMinimalPerf.default 278 570 0.49:1
BoxMinimalPerf.default 305 888 0.34:1

@chrisdholt chrisdholt merged commit e9e7f43 into microsoft:master Nov 2, 2021
@chrisdholt chrisdholt deleted the users/chhol/fix-cursor-issue-text-field branch November 3, 2021 01:27
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* change input state styles to fix height and prevent z-index from blocking cursor

* Change files

* oopsie copy paste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Once set cursor position of active TextField not changable
6 participants