fix: addressed high contrast visual on web components #20418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamudom
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
📊 Bundle size report🤖 This report was generated against bcde40e5d58a8b43d762cb92841471abd7e4b89e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bcde40e5d58a8b43d762cb92841471abd7e4b89e (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 119680a:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 925 | 945 | 5000 | |
| BaseButton | mount | 947 | 949 | 5000 | |
| Breadcrumb | mount | 2662 | 2652 | 1000 | |
| ButtonNext | mount | 519 | 504 | 5000 | |
| Checkbox | mount | 1617 | 1579 | 5000 | |
| CheckboxBase | mount | 1323 | 1305 | 5000 | |
| ChoiceGroup | mount | 4869 | 4764 | 5000 | |
| ComboBox | mount | 986 | 976 | 1000 | |
| CommandBar | mount | 10420 | 10343 | 1000 | |
| ContextualMenu | mount | 6636 | 6581 | 1000 | |
| DefaultButton | mount | 1197 | 1174 | 5000 | |
| DetailsRow | mount | 3919 | 3934 | 5000 | |
| DetailsRowFast | mount | 3911 | 3961 | 5000 | |
| DetailsRowNoStyles | mount | 3694 | 3682 | 5000 | |
| Dialog | mount | 2596 | 2652 | 1000 | |
| DocumentCardTitle | mount | 171 | 175 | 1000 | |
| Dropdown | mount | 3282 | 3342 | 5000 | |
| FluentProviderNext | mount | 3440 | 3500 | 5000 | |
| FluentProviderWithTheme | mount | 203 | 205 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 106 | 102 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 236 | 256 | 10 | |
| FocusTrapZone | mount | 1811 | 1835 | 5000 | |
| FocusZone | mount | 1818 | 1829 | 5000 | |
| IconButton | mount | 1818 | 1808 | 5000 | |
| Label | mount | 375 | 355 | 5000 | |
| Layer | mount | 3091 | 3044 | 5000 | |
| Link | mount | 487 | 482 | 5000 | |
| MakeStyles | mount | 1883 | 1881 | 50000 | |
| MenuButton | mount | 1475 | 1523 | 5000 | |
| MessageBar | mount | 2068 | 2139 | 5000 | |
| Nav | mount | 3366 | 3368 | 1000 | |
| OverflowSet | mount | 1177 | 1157 | 5000 | |
| Panel | mount | 2547 | 2583 | 1000 | |
| Persona | mount | 881 | 869 | 1000 | |
| Pivot | mount | 1475 | 1486 | 1000 | |
| PrimaryButton | mount | 1293 | 1337 | 5000 | |
| Rating | mount | 7810 | 7789 | 5000 | |
| SearchBox | mount | 1368 | 1349 | 5000 | |
| Shimmer | mount | 2644 | 2626 | 5000 | |
| Slider | mount | 2000 | 2052 | 5000 | |
| SpinButton | mount | 5152 | 5098 | 5000 | |
| Spinner | mount | 435 | 455 | 5000 | |
| SplitButton | mount | 3554 | 3243 | 5000 | |
| Stack | mount | 523 | 523 | 5000 | |
| StackWithIntrinsicChildren | mount | 1738 | 1726 | 5000 | |
| StackWithTextChildren | mount | 4747 | 4708 | 5000 | |
| SwatchColorPicker | mount | 10832 | 10560 | 5000 | |
| TagPicker | mount | 2761 | 2696 | 5000 | |
| TeachingBubble | mount | 13374 | 13347 | 5000 | |
| Text | mount | 471 | 453 | 5000 | |
| TextField | mount | 1435 | 1472 | 5000 | |
| ThemeProvider | mount | 1232 | 1237 | 5000 | |
| ThemeProvider | virtual-rerender | 650 | 630 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1958 | 1942 | 5000 | |
| Toggle | mount | 842 | 840 | 5000 | |
| buttonNative | mount | 141 | 148 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AlertMinimalPerf.default | 291 | 289 | 1.01:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 168 | 153 | 1.1:1 |
| PortalMinimalPerf.default | 191 | 176 | 1.09:1 |
| AvatarMinimalPerf.default | 206 | 193 | 1.07:1 |
| RefMinimalPerf.default | 257 | 244 | 1.05:1 |
| CardMinimalPerf.default | 586 | 561 | 1.04:1 |
| CarouselMinimalPerf.default | 471 | 452 | 1.04:1 |
| PopupMinimalPerf.default | 615 | 594 | 1.04:1 |
| SkeletonMinimalPerf.default | 361 | 347 | 1.04:1 |
| TooltipMinimalPerf.default | 1068 | 1026 | 1.04:1 |
| BoxMinimalPerf.default | 366 | 357 | 1.03:1 |
| DialogMinimalPerf.default | 772 | 750 | 1.03:1 |
| LayoutMinimalPerf.default | 387 | 376 | 1.03:1 |
| ListNestedPerf.default | 573 | 554 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1704 | 1659 | 1.03:1 |
| ReactionMinimalPerf.default | 390 | 379 | 1.03:1 |
| TableManyItemsPerf.default | 1974 | 1910 | 1.03:1 |
| AnimationMinimalPerf.default | 426 | 417 | 1.02:1 |
| CheckboxMinimalPerf.default | 2830 | 2787 | 1.02:1 |
| FlexMinimalPerf.default | 287 | 282 | 1.02:1 |
| LabelMinimalPerf.default | 402 | 393 | 1.02:1 |
| LoaderMinimalPerf.default | 725 | 712 | 1.02:1 |
| CustomToolbarPrototype.default | 4180 | 4117 | 1.02:1 |
| TreeMinimalPerf.default | 811 | 795 | 1.02:1 |
| AccordionMinimalPerf.default | 150 | 149 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1802 | 1776 | 1.01:1 |
| ButtonSlotsPerf.default | 570 | 567 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 308 | 304 | 1.01:1 |
| ChatMinimalPerf.default | 644 | 637 | 1.01:1 |
| ChatWithPopoverPerf.default | 393 | 391 | 1.01:1 |
| DatepickerMinimalPerf.default | 5548 | 5519 | 1.01:1 |
| DividerMinimalPerf.default | 368 | 363 | 1.01:1 |
| ListMinimalPerf.default | 501 | 497 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1788 | 1770 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4280 | 4255 | 1.01:1 |
| TableMinimalPerf.default | 411 | 405 | 1.01:1 |
| TextMinimalPerf.default | 347 | 345 | 1.01:1 |
| AttachmentSlotsPerf.default | 1065 | 1065 | 1:1 |
| DropdownManyItemsPerf.default | 684 | 685 | 1:1 |
| FormMinimalPerf.default | 408 | 410 | 1:1 |
| InputMinimalPerf.default | 1332 | 1330 | 1:1 |
| ItemLayoutMinimalPerf.default | 1228 | 1233 | 1:1 |
| MenuMinimalPerf.default | 843 | 844 | 1:1 |
| RosterPerf.default | 1191 | 1191 | 1:1 |
| ProviderMinimalPerf.default | 1122 | 1126 | 1:1 |
| SegmentMinimalPerf.default | 349 | 349 | 1:1 |
| StatusMinimalPerf.default | 683 | 685 | 1:1 |
| VideoMinimalPerf.default | 632 | 630 | 1:1 |
| EmbedMinimalPerf.default | 4291 | 4334 | 0.99:1 |
| GridMinimalPerf.default | 339 | 343 | 0.99:1 |
| HeaderSlotsPerf.default | 760 | 766 | 0.99:1 |
| ListWith60ListItems.default | 686 | 691 | 0.99:1 |
| SliderMinimalPerf.default | 1712 | 1722 | 0.99:1 |
| IconMinimalPerf.default | 621 | 625 | 0.99:1 |
| TextAreaMinimalPerf.default | 495 | 499 | 0.99:1 |
| ToolbarMinimalPerf.default | 939 | 947 | 0.99:1 |
| DropdownMinimalPerf.default | 3197 | 3246 | 0.98:1 |
| ButtonMinimalPerf.default | 173 | 179 | 0.97:1 |
| ImageMinimalPerf.default | 377 | 387 | 0.97:1 |
| ListCommonPerf.default | 622 | 643 | 0.97:1 |
| TreeWith60ListItems.default | 177 | 183 | 0.97:1 |
| HeaderMinimalPerf.default | 359 | 373 | 0.96:1 |
| RadioGroupMinimalPerf.default | 451 | 468 | 0.96:1 |
EisenbergEffect
approved these changes
Nov 1, 2021
khamudom
force-pushed
the
users/khamu/visual-update-hc
branch
from
918c529
to
4caafce
Compare
bheston
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
As you know, I was seeing different treatment than you, so I wasn't able to visually review this change. I can't assume what I'm seeing is correct. I reviewed the changes as best I could in code. I think this is much stronger than what we have now, so even if there are still a few issues I approve to merge this work. Thanks!
|
Smoke tested. This is a big improvement--thanks, @khamudom! |
chrisdholt
approved these changes
Nov 2, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* addressed high contrast on components and storybook controls * fixed step icon in numberfield * Change files * fixed import order * fixed disable button * removed high contrast query in storybook files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
These changes fix the high contrast colors on certain components. These issues were a regression from the visual update.
I also added some high contrast fixes on some control in storybook.
Focus areas to test
(optional)