Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Button): use event.key for keyboard event #19638

Merged
merged 2 commits into from
Sep 5, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Sep 3, 2021

Pull request checklist

Description of changes

Removes dependency from @fluentui/keyboard-key and switches to the converged @fluentui/keyboard-keys implemeting #18587 and bringing all converged dependencies to alpha to be ready to release for lockstep for #19106

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 3, 2021

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-button
Button
20.834 kB
5.928 kB
22.932 kB
6.984 kB
-2.098 kB
-1.056 kB
react-button
CompoundButton
26.108 kB
6.751 kB
28.215 kB
7.834 kB
-2.107 kB
-1.083 kB
react-button
MenuButton
22.633 kB
6.469 kB
24.733 kB
7.546 kB
-2.1 kB
-1.077 kB
react-button
ToggleButton
30.427 kB
6.526 kB
32.527 kB
7.601 kB
-2.1 kB
-1.075 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
166.545 kB
48.039 kB
166.545 kB
48.053 kB

-14 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: FluentProvider & webLightTheme
36.258 kB
11.596 kB
🤖 This report was generated against ed1de3abb2d386b7ab5dae275063a9a4777ee9b0

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68d1598:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 3, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ed1de3abb2d386b7ab5dae275063a9a4777ee9b0 (build)

@ling1726 ling1726 marked this pull request as ready for review September 3, 2021 08:06
@ling1726 ling1726 requested review from dzearing, khmakoto and a team as code owners September 3, 2021 08:06
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 851 870 5000
BaseButton mount 861 863 5000
Breadcrumb mount 2485 2506 1000
ButtonNext mount 415 410 5000
Checkbox mount 1405 1422 5000
CheckboxBase mount 1201 1199 5000
ChoiceGroup mount 4493 4451 5000
ComboBox mount 918 909 1000
CommandBar mount 9575 9559 1000
ContextualMenu mount 5921 5902 1000
DefaultButton mount 1053 1043 5000
DetailsRow mount 3450 3476 5000
DetailsRowFast mount 3526 3484 5000
DetailsRowNoStyles mount 3321 3307 5000
Dialog mount 1998 2069 1000
DocumentCardTitle mount 120 134 1000
Dropdown mount 3044 3095 5000
FluentProviderNext mount 7084 7081 5000
FocusTrapZone mount 1691 1726 5000
FocusZone mount 1693 1673 5000
IconButton mount 1629 1629 5000
Label mount 305 307 5000
Layer mount 1653 1698 5000
Link mount 425 435 5000
MakeStyles mount 1751 1717 50000
MenuButton mount 1359 1359 5000
MessageBar mount 1856 1893 5000
Nav mount 3084 2998 1000
OverflowSet mount 1033 1044 5000
Panel mount 2063 1981 1000
Persona mount 768 802 1000
Pivot mount 1312 1311 1000
PrimaryButton mount 1179 1185 5000
Rating mount 7090 7091 5000
SearchBox mount 1251 1219 5000
Shimmer mount 2360 2308 5000
Slider mount 1845 1800 5000
SpinButton mount 4731 4679 5000
Spinner mount 381 386 5000
SplitButton mount 2945 2958 5000
Stack mount 464 475 5000
StackWithIntrinsicChildren mount 1398 1450 5000
StackWithTextChildren mount 4168 4203 5000
SwatchColorPicker mount 9595 9558 5000
Tabs mount 1295 1302 1000
TagPicker mount 2434 2428 5000
TeachingBubble mount 11236 11152 5000
Text mount 384 377 5000
TextField mount 1308 1304 5000
ThemeProvider mount 1111 1111 5000
ThemeProvider virtual-rerender 574 567 5000
Toggle mount 755 747 5000
buttonNative mount 101 106 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 153 137 1.12:1
PortalMinimalPerf.default 175 159 1.1:1
AccordionMinimalPerf.default 140 129 1.09:1
ListCommonPerf.default 595 550 1.08:1
FlexMinimalPerf.default 275 256 1.07:1
ChatDuplicateMessagesPerf.default 274 261 1.05:1
AvatarMinimalPerf.default 186 178 1.04:1
ImageMinimalPerf.default 355 340 1.04:1
ToolbarMinimalPerf.default 881 845 1.04:1
TreeWith60ListItems.default 165 158 1.04:1
AnimationMinimalPerf.default 387 374 1.03:1
ButtonSlotsPerf.default 503 488 1.03:1
CardMinimalPerf.default 510 496 1.03:1
GridMinimalPerf.default 318 308 1.03:1
ProviderMinimalPerf.default 940 913 1.03:1
StatusMinimalPerf.default 636 620 1.03:1
IconMinimalPerf.default 578 563 1.03:1
BoxMinimalPerf.default 328 320 1.02:1
DropdownManyItemsPerf.default 644 633 1.02:1
HeaderMinimalPerf.default 332 326 1.02:1
InputMinimalPerf.default 1184 1156 1.02:1
ItemLayoutMinimalPerf.default 1130 1113 1.02:1
PopupMinimalPerf.default 551 541 1.02:1
SegmentMinimalPerf.default 326 320 1.02:1
SplitButtonMinimalPerf.default 3875 3808 1.02:1
TreeMinimalPerf.default 747 732 1.02:1
AttachmentSlotsPerf.default 991 983 1.01:1
ButtonOverridesMissPerf.default 1577 1566 1.01:1
CarouselMinimalPerf.default 427 421 1.01:1
CheckboxMinimalPerf.default 2577 2548 1.01:1
DialogMinimalPerf.default 705 700 1.01:1
LabelMinimalPerf.default 354 351 1.01:1
ListNestedPerf.default 509 503 1.01:1
RefMinimalPerf.default 222 219 1.01:1
TextMinimalPerf.default 320 318 1.01:1
CustomToolbarPrototype.default 3632 3608 1.01:1
AlertMinimalPerf.default 253 254 1:1
ChatMinimalPerf.default 608 608 1:1
DividerMinimalPerf.default 331 330 1:1
LayoutMinimalPerf.default 348 347 1:1
ListMinimalPerf.default 471 470 1:1
LoaderMinimalPerf.default 652 651 1:1
MenuButtonMinimalPerf.default 1530 1535 1:1
ProviderMergeThemesPerf.default 1557 1559 1:1
RadioGroupMinimalPerf.default 409 410 1:1
ReactionMinimalPerf.default 350 351 1:1
SkeletonMinimalPerf.default 326 325 1:1
SliderMinimalPerf.default 1461 1465 1:1
TableManyItemsPerf.default 1767 1771 1:1
TextAreaMinimalPerf.default 463 462 1:1
DatepickerMinimalPerf.default 5066 5111 0.99:1
DropdownMinimalPerf.default 2890 2923 0.99:1
EmbedMinimalPerf.default 3820 3844 0.99:1
MenuMinimalPerf.default 776 782 0.99:1
TableMinimalPerf.default 370 372 0.99:1
TooltipMinimalPerf.default 933 946 0.99:1
ButtonMinimalPerf.default 147 150 0.98:1
FormMinimalPerf.default 362 368 0.98:1
HeaderSlotsPerf.default 689 701 0.98:1
VideoMinimalPerf.default 578 588 0.98:1
ChatWithPopoverPerf.default 316 326 0.97:1
RosterPerf.default 1081 1113 0.97:1
ListWith60ListItems.default 570 601 0.95:1

@ling1726 ling1726 merged commit c3b21e8 into microsoft:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants