-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply fast package updates #19636
apply fast package updates #19636
Conversation
Updating my fork with changes
Wanted latest master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of quick changes if you can
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d66d7fb:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2760f658465d527e22edc13b73dcc3870dcbe62d (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 936 | 940 | 5000 | |
BaseButton | mount | 933 | 930 | 5000 | |
Breadcrumb | mount | 2701 | 2812 | 1000 | |
ButtonNext | mount | 462 | 458 | 5000 | |
Checkbox | mount | 1572 | 1567 | 5000 | |
CheckboxBase | mount | 1371 | 1339 | 5000 | |
ChoiceGroup | mount | 4880 | 4900 | 5000 | |
ComboBox | mount | 1030 | 1041 | 1000 | |
CommandBar | mount | 10683 | 10649 | 1000 | |
ContextualMenu | mount | 6388 | 6396 | 1000 | |
DefaultButton | mount | 1141 | 1154 | 5000 | |
DetailsRow | mount | 3838 | 3843 | 5000 | |
DetailsRowFast | mount | 3827 | 3933 | 5000 | |
DetailsRowNoStyles | mount | 3621 | 3649 | 5000 | |
Dialog | mount | 2208 | 2242 | 1000 | |
DocumentCardTitle | mount | 158 | 151 | 1000 | |
Dropdown | mount | 3279 | 3332 | 5000 | |
FluentProviderNext | mount | 7717 | 7600 | 5000 | |
FocusTrapZone | mount | 1887 | 1865 | 5000 | |
FocusZone | mount | 1889 | 1828 | 5000 | |
IconButton | mount | 1796 | 1787 | 5000 | |
Label | mount | 337 | 352 | 5000 | |
Layer | mount | 1859 | 1829 | 5000 | |
Link | mount | 485 | 483 | 5000 | |
MakeStyles | mount | 1837 | 1888 | 50000 | |
MenuButton | mount | 1524 | 1508 | 5000 | |
MessageBar | mount | 2146 | 2232 | 5000 | |
Nav | mount | 3445 | 3427 | 1000 | |
OverflowSet | mount | 1144 | 1203 | 5000 | |
Panel | mount | 1436 | 2226 | 1000 | |
Persona | mount | 889 | 933 | 1000 | |
Pivot | mount | 1455 | 1479 | 1000 | |
PrimaryButton | mount | 1324 | 1339 | 5000 | |
Rating | mount | 7838 | 7808 | 5000 | |
SearchBox | mount | 1356 | 1361 | 5000 | |
Shimmer | mount | 2581 | 2696 | 5000 | |
Slider | mount | 2037 | 1984 | 5000 | |
SpinButton | mount | 5145 | 5146 | 5000 | |
Spinner | mount | 431 | 452 | 5000 | |
SplitButton | mount | 3293 | 3219 | 5000 | |
Stack | mount | 520 | 517 | 5000 | |
StackWithIntrinsicChildren | mount | 1582 | 1553 | 5000 | |
StackWithTextChildren | mount | 4618 | 4638 | 5000 | |
SwatchColorPicker | mount | 10475 | 10542 | 5000 | |
Tabs | mount | 1401 | 1453 | 1000 | |
TagPicker | mount | 2716 | 2633 | 5000 | |
TeachingBubble | mount | 12417 | 12282 | 5000 | |
Text | mount | 439 | 430 | 5000 | |
TextField | mount | 1416 | 1430 | 5000 | |
ThemeProvider | mount | 1238 | 1226 | 5000 | |
ThemeProvider | virtual-rerender | 610 | 625 | 5000 | |
Toggle | mount | 837 | 814 | 5000 | |
buttonNative | mount | 107 | 121 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 178 | 152 | 1.17:1 |
AvatarMinimalPerf.default | 202 | 189 | 1.07:1 |
ListWith60ListItems.default | 683 | 640 | 1.07:1 |
VideoMinimalPerf.default | 668 | 627 | 1.07:1 |
SkeletonMinimalPerf.default | 375 | 354 | 1.06:1 |
AccordionMinimalPerf.default | 157 | 149 | 1.05:1 |
FlexMinimalPerf.default | 290 | 275 | 1.05:1 |
LayoutMinimalPerf.default | 377 | 359 | 1.05:1 |
ListMinimalPerf.default | 514 | 490 | 1.05:1 |
AnimationMinimalPerf.default | 427 | 409 | 1.04:1 |
ChatMinimalPerf.default | 667 | 642 | 1.04:1 |
HeaderSlotsPerf.default | 776 | 749 | 1.04:1 |
ListCommonPerf.default | 637 | 612 | 1.04:1 |
PopupMinimalPerf.default | 628 | 604 | 1.04:1 |
AttachmentSlotsPerf.default | 1103 | 1073 | 1.03:1 |
BoxMinimalPerf.default | 360 | 351 | 1.03:1 |
ButtonMinimalPerf.default | 169 | 164 | 1.03:1 |
CardMinimalPerf.default | 565 | 551 | 1.03:1 |
CarouselMinimalPerf.default | 476 | 460 | 1.03:1 |
ChatDuplicateMessagesPerf.default | 300 | 292 | 1.03:1 |
ButtonSlotsPerf.default | 563 | 554 | 1.02:1 |
DatepickerMinimalPerf.default | 5735 | 5647 | 1.02:1 |
DropdownMinimalPerf.default | 3221 | 3166 | 1.02:1 |
FormMinimalPerf.default | 404 | 398 | 1.02:1 |
ItemLayoutMinimalPerf.default | 1246 | 1221 | 1.02:1 |
MenuMinimalPerf.default | 878 | 857 | 1.02:1 |
ProviderMergeThemesPerf.default | 1743 | 1710 | 1.02:1 |
RadioGroupMinimalPerf.default | 457 | 450 | 1.02:1 |
SliderMinimalPerf.default | 1602 | 1577 | 1.02:1 |
IconMinimalPerf.default | 642 | 627 | 1.02:1 |
TableManyItemsPerf.default | 1968 | 1934 | 1.02:1 |
TextMinimalPerf.default | 348 | 341 | 1.02:1 |
AlertMinimalPerf.default | 286 | 283 | 1.01:1 |
LoaderMinimalPerf.default | 708 | 703 | 1.01:1 |
MenuButtonMinimalPerf.default | 1678 | 1655 | 1.01:1 |
ReactionMinimalPerf.default | 375 | 372 | 1.01:1 |
TextAreaMinimalPerf.default | 493 | 489 | 1.01:1 |
TreeMinimalPerf.default | 810 | 801 | 1.01:1 |
TreeWith60ListItems.default | 171 | 170 | 1.01:1 |
ButtonOverridesMissPerf.default | 1707 | 1713 | 1:1 |
DialogMinimalPerf.default | 772 | 771 | 1:1 |
EmbedMinimalPerf.default | 4237 | 4244 | 1:1 |
HeaderMinimalPerf.default | 361 | 362 | 1:1 |
InputMinimalPerf.default | 1293 | 1296 | 1:1 |
LabelMinimalPerf.default | 386 | 385 | 1:1 |
ListNestedPerf.default | 558 | 558 | 1:1 |
SplitButtonMinimalPerf.default | 4201 | 4190 | 1:1 |
StatusMinimalPerf.default | 692 | 691 | 1:1 |
TableMinimalPerf.default | 413 | 413 | 1:1 |
ToolbarMinimalPerf.default | 942 | 945 | 1:1 |
TooltipMinimalPerf.default | 1033 | 1033 | 1:1 |
ChatWithPopoverPerf.default | 363 | 366 | 0.99:1 |
CheckboxMinimalPerf.default | 2798 | 2822 | 0.99:1 |
DividerMinimalPerf.default | 358 | 361 | 0.99:1 |
PortalMinimalPerf.default | 170 | 172 | 0.99:1 |
SegmentMinimalPerf.default | 354 | 357 | 0.99:1 |
CustomToolbarPrototype.default | 3913 | 3946 | 0.99:1 |
DropdownManyItemsPerf.default | 676 | 687 | 0.98:1 |
ImageMinimalPerf.default | 373 | 379 | 0.98:1 |
RefMinimalPerf.default | 242 | 246 | 0.98:1 |
ProviderMinimalPerf.default | 992 | 1027 | 0.97:1 |
GridMinimalPerf.default | 340 | 353 | 0.96:1 |
RosterPerf.default | 1154 | 1212 | 0.95:1 |
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
apply fast package updates
Focus areas to test
(optional)