Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply fast package updates #19636

Merged
merged 33 commits into from
Sep 2, 2021

Conversation

eljefe223
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

apply fast package updates

Focus areas to test

(optional)

eljefe223 and others added 30 commits September 17, 2020 15:03
Updating my fork with changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of quick changes if you can

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d66d7fb:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 2, 2021

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
55.21 kB
17.401 kB
react-avatar
Avatar
56.558 kB
15.66 kB
react-badge
Badge
24.343 kB
7.165 kB
react-badge
CounterBadge
27.156 kB
7.851 kB
react-badge
PresenseBadge
237 B
177 B
react-button
Button
25.03 kB
8.04 kB
react-button
CompoundButton
30.322 kB
8.917 kB
react-button
MenuButton
26.833 kB
8.623 kB
react-button
ToggleButton
34.627 kB
8.676 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
166.545 kB
48.067 kB
react-components
react-components: FluentProvider & webLightTheme
36.258 kB
11.596 kB
react-divider
Divider
15.889 kB
5.747 kB
react-image
Image
10.642 kB
4.264 kB
react-input
Input
31.636 kB
11.312 kB
react-label
Label
9.397 kB
3.839 kB
react-link
Link
14.715 kB
6.012 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.557 kB
1.202 kB
react-menu
Menu (including children components)
106.042 kB
32.735 kB
react-menu
Menu (including selectable components)
108.802 kB
33.277 kB
react-popover
Popover
102.804 kB
31.283 kB
react-portal
Portal
7.78 kB
2.672 kB
react-positioning
usePopper
23.145 kB
7.942 kB
react-provider
FluentProvider
16.256 kB
5.969 kB
react-slider
Slider
28.975 kB
9.115 kB
react-text
Text - Default
11.798 kB
4.452 kB
react-text
Text - Wrappers
15.414 kB
4.734 kB
react-theme
Teams: all themes
32.941 kB
6.674 kB
react-theme
Teams: Light theme
20.247 kB
5.662 kB
react-tooltip
Tooltip
46.054 kB
15.658 kB
react-utilities
SSRProvider
213 B
170 B
🤖 This report was generated against 2760f658465d527e22edc13b73dcc3870dcbe62d

@size-auditor
Copy link

size-auditor bot commented Sep 2, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2760f658465d527e22edc13b73dcc3870dcbe62d (build)

@eljefe223 eljefe223 enabled auto-merge (squash) September 2, 2021 22:20
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 936 940 5000
BaseButton mount 933 930 5000
Breadcrumb mount 2701 2812 1000
ButtonNext mount 462 458 5000
Checkbox mount 1572 1567 5000
CheckboxBase mount 1371 1339 5000
ChoiceGroup mount 4880 4900 5000
ComboBox mount 1030 1041 1000
CommandBar mount 10683 10649 1000
ContextualMenu mount 6388 6396 1000
DefaultButton mount 1141 1154 5000
DetailsRow mount 3838 3843 5000
DetailsRowFast mount 3827 3933 5000
DetailsRowNoStyles mount 3621 3649 5000
Dialog mount 2208 2242 1000
DocumentCardTitle mount 158 151 1000
Dropdown mount 3279 3332 5000
FluentProviderNext mount 7717 7600 5000
FocusTrapZone mount 1887 1865 5000
FocusZone mount 1889 1828 5000
IconButton mount 1796 1787 5000
Label mount 337 352 5000
Layer mount 1859 1829 5000
Link mount 485 483 5000
MakeStyles mount 1837 1888 50000
MenuButton mount 1524 1508 5000
MessageBar mount 2146 2232 5000
Nav mount 3445 3427 1000
OverflowSet mount 1144 1203 5000
Panel mount 1436 2226 1000
Persona mount 889 933 1000
Pivot mount 1455 1479 1000
PrimaryButton mount 1324 1339 5000
Rating mount 7838 7808 5000
SearchBox mount 1356 1361 5000
Shimmer mount 2581 2696 5000
Slider mount 2037 1984 5000
SpinButton mount 5145 5146 5000
Spinner mount 431 452 5000
SplitButton mount 3293 3219 5000
Stack mount 520 517 5000
StackWithIntrinsicChildren mount 1582 1553 5000
StackWithTextChildren mount 4618 4638 5000
SwatchColorPicker mount 10475 10542 5000
Tabs mount 1401 1453 1000
TagPicker mount 2716 2633 5000
TeachingBubble mount 12417 12282 5000
Text mount 439 430 5000
TextField mount 1416 1430 5000
ThemeProvider mount 1238 1226 5000
ThemeProvider virtual-rerender 610 625 5000
Toggle mount 837 814 5000
buttonNative mount 107 121 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 178 152 1.17:1
AvatarMinimalPerf.default 202 189 1.07:1
ListWith60ListItems.default 683 640 1.07:1
VideoMinimalPerf.default 668 627 1.07:1
SkeletonMinimalPerf.default 375 354 1.06:1
AccordionMinimalPerf.default 157 149 1.05:1
FlexMinimalPerf.default 290 275 1.05:1
LayoutMinimalPerf.default 377 359 1.05:1
ListMinimalPerf.default 514 490 1.05:1
AnimationMinimalPerf.default 427 409 1.04:1
ChatMinimalPerf.default 667 642 1.04:1
HeaderSlotsPerf.default 776 749 1.04:1
ListCommonPerf.default 637 612 1.04:1
PopupMinimalPerf.default 628 604 1.04:1
AttachmentSlotsPerf.default 1103 1073 1.03:1
BoxMinimalPerf.default 360 351 1.03:1
ButtonMinimalPerf.default 169 164 1.03:1
CardMinimalPerf.default 565 551 1.03:1
CarouselMinimalPerf.default 476 460 1.03:1
ChatDuplicateMessagesPerf.default 300 292 1.03:1
ButtonSlotsPerf.default 563 554 1.02:1
DatepickerMinimalPerf.default 5735 5647 1.02:1
DropdownMinimalPerf.default 3221 3166 1.02:1
FormMinimalPerf.default 404 398 1.02:1
ItemLayoutMinimalPerf.default 1246 1221 1.02:1
MenuMinimalPerf.default 878 857 1.02:1
ProviderMergeThemesPerf.default 1743 1710 1.02:1
RadioGroupMinimalPerf.default 457 450 1.02:1
SliderMinimalPerf.default 1602 1577 1.02:1
IconMinimalPerf.default 642 627 1.02:1
TableManyItemsPerf.default 1968 1934 1.02:1
TextMinimalPerf.default 348 341 1.02:1
AlertMinimalPerf.default 286 283 1.01:1
LoaderMinimalPerf.default 708 703 1.01:1
MenuButtonMinimalPerf.default 1678 1655 1.01:1
ReactionMinimalPerf.default 375 372 1.01:1
TextAreaMinimalPerf.default 493 489 1.01:1
TreeMinimalPerf.default 810 801 1.01:1
TreeWith60ListItems.default 171 170 1.01:1
ButtonOverridesMissPerf.default 1707 1713 1:1
DialogMinimalPerf.default 772 771 1:1
EmbedMinimalPerf.default 4237 4244 1:1
HeaderMinimalPerf.default 361 362 1:1
InputMinimalPerf.default 1293 1296 1:1
LabelMinimalPerf.default 386 385 1:1
ListNestedPerf.default 558 558 1:1
SplitButtonMinimalPerf.default 4201 4190 1:1
StatusMinimalPerf.default 692 691 1:1
TableMinimalPerf.default 413 413 1:1
ToolbarMinimalPerf.default 942 945 1:1
TooltipMinimalPerf.default 1033 1033 1:1
ChatWithPopoverPerf.default 363 366 0.99:1
CheckboxMinimalPerf.default 2798 2822 0.99:1
DividerMinimalPerf.default 358 361 0.99:1
PortalMinimalPerf.default 170 172 0.99:1
SegmentMinimalPerf.default 354 357 0.99:1
CustomToolbarPrototype.default 3913 3946 0.99:1
DropdownManyItemsPerf.default 676 687 0.98:1
ImageMinimalPerf.default 373 379 0.98:1
RefMinimalPerf.default 242 246 0.98:1
ProviderMinimalPerf.default 992 1027 0.97:1
GridMinimalPerf.default 340 353 0.96:1
RosterPerf.default 1154 1212 0.95:1

@eljefe223 eljefe223 merged commit 65fc391 into microsoft:master Sep 2, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.4.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants