Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast dependencies version bump #19548

Merged
merged 29 commits into from
Aug 27, 2021

Conversation

eljefe223
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Fast dependencies version bump

Focus areas to test

(optional)

eljefe223 and others added 25 commits September 17, 2020 15:03
Updating my fork with changes
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 449dffb:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 27, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 28476bf50b064ba5a939371df350167d685f8e39 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 27, 2021

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
75.787 kB
22.366 kB
react-avatar
Avatar
56.558 kB
15.66 kB
react-badge
Badge
24.343 kB
7.165 kB
react-badge
CounterBadge
27.156 kB
7.851 kB
react-badge
PresenseBadge
237 B
177 B
react-button
Button
25.016 kB
8.035 kB
react-button
CompoundButton
30.308 kB
8.911 kB
react-button
MenuButton
26.603 kB
8.543 kB
react-button
ToggleButton
34.613 kB
8.671 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
177.666 kB
50.281 kB
react-components
react-components: FluentProvider & webLightTheme
36.288 kB
11.615 kB
react-divider
Divider
15.889 kB
5.747 kB
react-image
Image
10.642 kB
4.264 kB
react-label
Label
9.397 kB
3.839 kB
react-link
Link
14.715 kB
6.012 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.557 kB
1.202 kB
react-menu
Menu (including children components)
115.15 kB
34.665 kB
react-menu
Menu (including selectable components)
117.88 kB
35.217 kB
react-popover
Popover
124.599 kB
36.198 kB
react-portal
Portal
7.78 kB
2.672 kB
react-positioning
usePopper
23.145 kB
7.942 kB
react-provider
FluentProvider
16.286 kB
5.991 kB
react-text
Text - Default
11.798 kB
4.452 kB
react-text
Text - Wrappers
15.414 kB
4.734 kB
react-theme
Teams: all themes
32.941 kB
6.674 kB
react-theme
Teams: Light theme
20.247 kB
5.662 kB
react-tooltip
Tooltip
46.054 kB
15.658 kB
react-utilities
SSRProvider
213 B
170 B
🤖 This report was generated against 28476bf50b064ba5a939371df350167d685f8e39

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 27, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 961 991 5000
BaseButton mount 957 956 5000
Breadcrumb mount 2657 2601 1000
ButtonNext mount 454 445 5000
Checkbox mount 1622 1736 5000
CheckboxBase mount 1394 1375 5000
ChoiceGroup mount 4984 4969 5000
ComboBox mount 999 992 1000
CommandBar mount 10171 10164 1000
ContextualMenu mount 6184 6324 1000
DefaultButton mount 1203 1190 5000
DetailsRow mount 3882 3868 5000
DetailsRowFast mount 3896 3871 5000
DetailsRowNoStyles mount 3713 3696 5000
Dialog mount 2244 2236 1000
DocumentCardTitle mount 145 158 1000
Dropdown mount 3423 3402 5000
FluentProviderNext mount 7065 6945 5000
FocusTrapZone mount 1878 1836 5000
FocusZone mount 1823 1830 5000
IconButton mount 1919 1842 5000
Label mount 349 355 5000
Layer mount 1863 1800 5000
Link mount 489 479 5000
MakeStyles mount 1863 1830 50000
MenuButton mount 1568 1547 5000
MessageBar mount 2125 1980 5000
Nav mount 3408 3349 1000
OverflowSet mount 1117 1131 5000
Panel mount 2128 2120 1000
Persona mount 882 842 1000
Pivot mount 1465 1451 1000
PrimaryButton mount 1333 1352 5000
Rating mount 8300 8081 5000
SearchBox mount 1497 1420 5000
Shimmer mount 2736 2702 5000
Slider mount 2067 2053 5000
SpinButton mount 5128 5122 5000
Spinner mount 434 422 5000
SplitButton mount 3310 3338 5000
Stack mount 513 530 5000
StackWithIntrinsicChildren mount 1662 1686 5000
StackWithTextChildren mount 4939 4783 5000
SwatchColorPicker mount 10667 10561 5000
Tabs mount 1423 1472 1000
TagPicker mount 2725 2719 5000
TeachingBubble mount 12093 12041 5000
Text mount 441 424 5000
TextField mount 1490 1450 5000
ThemeProvider mount 1173 1226 5000
ThemeProvider virtual-rerender 641 602 5000
Toggle mount 817 830 5000
buttonNative mount 117 116 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 216 190 1.14:1
AttachmentMinimalPerf.default 172 157 1.1:1
ChatWithPopoverPerf.default 390 359 1.09:1
TreeWith60ListItems.default 186 173 1.08:1
VideoMinimalPerf.default 680 636 1.07:1
FlexMinimalPerf.default 311 294 1.06:1
PopupMinimalPerf.default 611 578 1.06:1
SegmentMinimalPerf.default 370 348 1.06:1
GridMinimalPerf.default 358 342 1.05:1
InputMinimalPerf.default 1387 1326 1.05:1
ListWith60ListItems.default 700 665 1.05:1
IconMinimalPerf.default 667 633 1.05:1
TreeMinimalPerf.default 848 811 1.05:1
AccordionMinimalPerf.default 165 159 1.04:1
BoxMinimalPerf.default 372 358 1.04:1
CarouselMinimalPerf.default 491 470 1.04:1
RadioGroupMinimalPerf.default 500 482 1.04:1
SplitButtonMinimalPerf.default 4452 4299 1.04:1
ChatMinimalPerf.default 689 668 1.03:1
ItemLayoutMinimalPerf.default 1302 1269 1.03:1
MenuMinimalPerf.default 885 858 1.03:1
RefMinimalPerf.default 231 224 1.03:1
ToolbarMinimalPerf.default 980 950 1.03:1
AttachmentSlotsPerf.default 1140 1119 1.02:1
DropdownManyItemsPerf.default 720 707 1.02:1
HeaderMinimalPerf.default 389 383 1.02:1
PortalMinimalPerf.default 171 168 1.02:1
ProviderMinimalPerf.default 1065 1041 1.02:1
ButtonOverridesMissPerf.default 1717 1698 1.01:1
ButtonSlotsPerf.default 590 585 1.01:1
DialogMinimalPerf.default 778 769 1.01:1
HeaderSlotsPerf.default 806 796 1.01:1
LayoutMinimalPerf.default 382 380 1.01:1
LoaderMinimalPerf.default 729 721 1.01:1
RosterPerf.default 1304 1288 1.01:1
SliderMinimalPerf.default 1618 1607 1.01:1
StatusMinimalPerf.default 716 707 1.01:1
TextAreaMinimalPerf.default 536 532 1.01:1
AnimationMinimalPerf.default 413 411 1:1
ChatDuplicateMessagesPerf.default 297 297 1:1
DividerMinimalPerf.default 372 371 1:1
DropdownMinimalPerf.default 3090 3097 1:1
EmbedMinimalPerf.default 4178 4194 1:1
ImageMinimalPerf.default 410 409 1:1
ListCommonPerf.default 671 673 1:1
MenuButtonMinimalPerf.default 1749 1755 1:1
ProviderMergeThemesPerf.default 1663 1666 1:1
ReactionMinimalPerf.default 413 415 1:1
CustomToolbarPrototype.default 3901 3890 1:1
TooltipMinimalPerf.default 1043 1043 1:1
AlertMinimalPerf.default 287 291 0.99:1
CheckboxMinimalPerf.default 2772 2793 0.99:1
DatepickerMinimalPerf.default 5487 5537 0.99:1
ListNestedPerf.default 580 587 0.99:1
TableManyItemsPerf.default 2021 2049 0.99:1
ListMinimalPerf.default 536 546 0.98:1
SkeletonMinimalPerf.default 363 369 0.98:1
TextMinimalPerf.default 366 377 0.97:1
LabelMinimalPerf.default 396 412 0.96:1
ButtonMinimalPerf.default 178 187 0.95:1
TableMinimalPerf.default 413 435 0.95:1
CardMinimalPerf.default 584 628 0.93:1
FormMinimalPerf.default 422 463 0.91:1

@eljefe223 eljefe223 enabled auto-merge (squash) August 27, 2021 16:19
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the build changes

@eljefe223 eljefe223 merged commit 997099c into microsoft:master Aug 27, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.3.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants