Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a11y-testing): use new keyboard-keys package #19012

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Jul 20, 2021

First step to full migration per #18587

Adds keyboard-keys as a dependency to a11y-testing and uses both
keyCodes and keys

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

First step to full migration per #<RFC here>

Adds `keyboard-keys` as a dependency to `a11y-testing` and uses both
keyCodes and keys
"enzyme": "~3.10.0",
"react": "16.8.6"
},
"dependencies": {
"@fluentui/keyboard-keys": "^9.0.0-alpha.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only change, everything else is sorting

@size-auditor
Copy link

size-auditor bot commented Jul 20, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cf8d7a43d6de92501cef58200aff21fb3d1590a5 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58cbc5a:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against cf8d7a43d6de92501cef58200aff21fb3d1590a5

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 796 794 5000
BaseButton mount 863 884 5000
Breadcrumb mount 2542 2581 1000
ButtonNext mount 518 507 5000
Checkbox mount 1453 1457 5000
CheckboxBase mount 1241 1265 5000
ChoiceGroup mount 4432 4536 5000
ComboBox mount 911 903 1000
CommandBar mount 9785 9693 1000
ContextualMenu mount 6033 6068 1000
DefaultButton mount 1063 1062 5000
DetailsRow mount 3533 3564 5000
DetailsRowFast mount 3580 3609 5000
DetailsRowNoStyles mount 3414 3379 5000
Dialog mount 2058 2043 1000
DocumentCardTitle mount 134 150 1000
Dropdown mount 3062 3057 5000
FluentProviderNext mount 6979 7000 5000
FocusTrapZone mount 1771 1680 5000
FocusZone mount 1753 1765 5000
IconButton mount 1652 1673 5000
Label mount 330 326 5000
Layer mount 1701 1654 5000
Link mount 443 446 5000
MakeStyles mount 1774 1771 50000
MenuButton mount 1390 1400 5000
MessageBar mount 1959 1955 5000
Nav mount 3091 3138 1000
OverflowSet mount 1004 1019 5000
Panel mount 1315 1993 1000
Persona mount 778 768 1000
Pivot mount 1314 1335 1000
PrimaryButton mount 1201 1193 5000
Rating mount 7217 7312 5000
SearchBox mount 1278 1263 5000
Shimmer mount 2483 2433 5000
Slider mount 1865 1851 5000
SpinButton mount 4746 4788 5000
Spinner mount 396 413 5000
SplitButton mount 3009 2987 5000
Stack mount 487 482 5000
StackWithIntrinsicChildren mount 1451 1447 5000
StackWithTextChildren mount 4318 4293 5000
SwatchColorPicker mount 9795 9726 5000
Tabs mount 1351 1338 1000
TagPicker mount 2294 2380 5000
TeachingBubble mount 11483 11385 5000
Text mount 384 417 5000
TextField mount 1297 1281 5000
ThemeProvider mount 1113 1097 5000
ThemeProvider virtual-rerender 585 575 5000
Toggle mount 763 789 5000
buttonNative mount 109 116 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 168 155 1.08:1
TreeWith60ListItems.default 168 156 1.08:1
HeaderMinimalPerf.default 342 320 1.07:1
AccordionMinimalPerf.default 141 134 1.05:1
PortalMinimalPerf.default 172 164 1.05:1
AlertMinimalPerf.default 264 255 1.04:1
AvatarMinimalPerf.default 188 181 1.04:1
CarouselMinimalPerf.default 449 433 1.04:1
GridMinimalPerf.default 328 316 1.04:1
ListCommonPerf.default 588 567 1.04:1
ListMinimalPerf.default 502 481 1.04:1
IconMinimalPerf.default 590 568 1.04:1
LoaderMinimalPerf.default 667 649 1.03:1
RadioGroupMinimalPerf.default 431 417 1.03:1
TextMinimalPerf.default 330 320 1.03:1
AttachmentSlotsPerf.default 1012 996 1.02:1
ChatMinimalPerf.default 609 595 1.02:1
DividerMinimalPerf.default 340 334 1.02:1
RefMinimalPerf.default 224 219 1.02:1
TooltipMinimalPerf.default 958 940 1.02:1
ButtonSlotsPerf.default 506 503 1.01:1
CheckboxMinimalPerf.default 2648 2620 1.01:1
EmbedMinimalPerf.default 3966 3916 1.01:1
ItemLayoutMinimalPerf.default 1151 1141 1.01:1
ProviderMergeThemesPerf.default 1579 1560 1.01:1
ReactionMinimalPerf.default 354 352 1.01:1
StatusMinimalPerf.default 658 651 1.01:1
VideoMinimalPerf.default 603 598 1.01:1
DialogMinimalPerf.default 726 723 1:1
DropdownManyItemsPerf.default 651 648 1:1
DropdownMinimalPerf.default 2986 2998 1:1
FormMinimalPerf.default 367 366 1:1
HeaderSlotsPerf.default 723 723 1:1
InputMinimalPerf.default 1190 1187 1:1
MenuMinimalPerf.default 805 806 1:1
MenuButtonMinimalPerf.default 1537 1541 1:1
PopupMinimalPerf.default 563 563 1:1
ProviderMinimalPerf.default 922 919 1:1
SkeletonMinimalPerf.default 323 324 1:1
SplitButtonMinimalPerf.default 3654 3650 1:1
TableManyItemsPerf.default 1790 1791 1:1
CustomToolbarPrototype.default 3662 3646 1:1
BoxMinimalPerf.default 329 331 0.99:1
ButtonOverridesMissPerf.default 1608 1632 0.99:1
CardMinimalPerf.default 510 514 0.99:1
ChatDuplicateMessagesPerf.default 283 285 0.99:1
DatepickerMinimalPerf.default 5133 5196 0.99:1
ImageMinimalPerf.default 341 345 0.99:1
LayoutMinimalPerf.default 345 348 0.99:1
ListNestedPerf.default 516 522 0.99:1
ListWith60ListItems.default 612 617 0.99:1
SegmentMinimalPerf.default 321 324 0.99:1
SliderMinimalPerf.default 1498 1509 0.99:1
TableMinimalPerf.default 378 380 0.99:1
TreeMinimalPerf.default 748 758 0.99:1
AnimationMinimalPerf.default 380 386 0.98:1
ChatWithPopoverPerf.default 318 329 0.97:1
FlexMinimalPerf.default 257 266 0.97:1
LabelMinimalPerf.default 362 374 0.97:1
TextAreaMinimalPerf.default 472 486 0.97:1
AttachmentMinimalPerf.default 134 140 0.96:1
RosterPerf.default 1073 1118 0.96:1
ToolbarMinimalPerf.default 877 910 0.96:1

@ling1726 ling1726 marked this pull request as ready for review July 20, 2021 08:58
@ling1726 ling1726 merged commit ae8112b into microsoft:master Jul 20, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
First step to full migration per #<RFC here>

Adds `keyboard-keys` as a dependency to `a11y-testing` and uses both
keyCodes and keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants