Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keyboard-keys): Export keys and legacy keyCodes #18896

Merged
merged 4 commits into from
Jul 15, 2021
Merged

feat(keyboard-keys): Export keys and legacy keyCodes #18896

merged 4 commits into from
Jul 15, 2021

Commits on Jul 11, 2021

  1. feat(keyboard-keys): Export keys and legacy keyCodes 

    This PR implements what was proposed in microsoft#18587 and exports all named
`key` values specified by w3c.

Also adds legacy keycode exports as a deep import. Happy to take any
suggestions to avoid this. Originallly this was the plan:

```ts
export * as keyCodes from './keyCodes'
```

but unfortunately API extractor does not support this syntax
microsoft/rushstack#2780
    @ling1726
    ling1726 committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    020a7c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Merge branch 'master' into feat/keyboard-keys

    @ling1726
    ling1726 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7d98fcd View commit details
    Browse the repository at this point in the history

  2. remove deep export

    @ling1726
    ling1726 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    4daf855 View commit details
    Browse the repository at this point in the history

  3. update fixture

    @ling1726
    ling1726 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    2b4f0fb View commit details
    Browse the repository at this point in the history