Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyboard-keys): Init new package (not published) #18815

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Jul 2, 2021

Initializes the auto-generated artifacts for the new
@fluentui/keyboard-keys package as proposed in #18587

Does not publish the package immediately

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Initializes the auto-generated artifacts for the new
`@fluentui/keyboard-keys` package as proposed in microsoft#18587

**Does not publish the package immediately**
@size-auditor
Copy link

size-auditor bot commented Jul 2, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6c37a1cb5c312d4be8b239bfd9f6c9f28e9f0d24 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 796 825 5000
BaseButton mount 896 898 5000
Breadcrumb mount 2678 2660 1000
ButtonNext mount 504 508 5000
Checkbox mount 1544 1477 5000
CheckboxBase mount 1342 1293 5000
ChoiceGroup mount 4774 4796 5000
ComboBox mount 981 971 1000
CommandBar mount 10196 10221 1000
ContextualMenu mount 6282 6286 1000
DefaultButton mount 1144 1130 5000
DetailsRow mount 3682 3692 5000
DetailsRowFast mount 3548 3594 5000
DetailsRowNoStyles mount 3419 3401 5000
Dialog mount 2097 2082 1000
DocumentCardTitle mount 125 150 1000
Dropdown mount 3084 3188 5000
FluentProviderNext mount 7018 7036 5000
FocusTrapZone mount 1708 1709 5000
FocusZone mount 1694 1724 5000
IconButton mount 1618 1602 5000
Label mount 315 316 5000
Layer mount 1690 1682 5000
Link mount 432 426 5000
MakeStyles mount 1744 1732 50000
MenuButton mount 1399 1423 5000
MessageBar mount 1912 1938 5000
Nav mount 3088 3086 1000
OverflowSet mount 975 968 5000
Panel mount 1966 1956 1000
Persona mount 800 776 1000
Pivot mount 1349 1339 1000
PrimaryButton mount 1211 1195 5000
Rating mount 7251 7165 5000
SearchBox mount 1245 1243 5000
Shimmer mount 2431 2403 5000
Slider mount 1881 1846 5000
SpinButton mount 4740 4765 5000
Spinner mount 409 377 5000
SplitButton mount 2979 2948 5000
Stack mount 478 467 5000
StackWithIntrinsicChildren mount 1427 1435 5000
StackWithTextChildren mount 4322 4348 5000
SwatchColorPicker mount 9869 9982 5000
Tabs mount 1316 1341 1000
TagPicker mount 2305 2309 5000
TeachingBubble mount 11372 11191 5000
Text mount 407 397 5000
TextField mount 1309 1303 5000
ThemeProvider mount 1140 1112 5000
ThemeProvider virtual-rerender 567 582 5000
Toggle mount 758 751 5000
buttonNative mount 115 100 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SkeletonMinimalPerf.default 372 350 1.06:1
IconMinimalPerf.default 646 611 1.06:1
AttachmentMinimalPerf.default 159 151 1.05:1
PortalMinimalPerf.default 182 174 1.05:1
AnimationMinimalPerf.default 420 405 1.04:1
ButtonMinimalPerf.default 176 170 1.04:1
ButtonSlotsPerf.default 576 556 1.04:1
InputMinimalPerf.default 1329 1281 1.04:1
LayoutMinimalPerf.default 377 361 1.04:1
VideoMinimalPerf.default 656 630 1.04:1
TreeWith60ListItems.default 169 164 1.03:1
AttachmentSlotsPerf.default 1116 1096 1.02:1
ButtonOverridesMissPerf.default 1725 1697 1.02:1
DialogMinimalPerf.default 765 752 1.02:1
DropdownManyItemsPerf.default 690 678 1.02:1
ItemLayoutMinimalPerf.default 1262 1232 1.02:1
ListWith60ListItems.default 654 644 1.02:1
MenuButtonMinimalPerf.default 1587 1556 1.02:1
PopupMinimalPerf.default 579 570 1.02:1
ReactionMinimalPerf.default 388 379 1.02:1
SliderMinimalPerf.default 1639 1604 1.02:1
AvatarMinimalPerf.default 196 194 1.01:1
ChatMinimalPerf.default 672 664 1.01:1
CheckboxMinimalPerf.default 2794 2772 1.01:1
DatepickerMinimalPerf.default 5534 5465 1.01:1
DividerMinimalPerf.default 364 360 1.01:1
DropdownMinimalPerf.default 3171 3137 1.01:1
EmbedMinimalPerf.default 4212 4160 1.01:1
GridMinimalPerf.default 348 345 1.01:1
ListCommonPerf.default 621 612 1.01:1
ListMinimalPerf.default 520 515 1.01:1
RadioGroupMinimalPerf.default 456 450 1.01:1
SegmentMinimalPerf.default 357 353 1.01:1
TableManyItemsPerf.default 1924 1905 1.01:1
ChatDuplicateMessagesPerf.default 280 279 1:1
LabelMinimalPerf.default 392 391 1:1
LoaderMinimalPerf.default 706 705 1:1
ProviderMergeThemesPerf.default 1687 1687 1:1
ProviderMinimalPerf.default 979 981 1:1
StatusMinimalPerf.default 692 692 1:1
CustomToolbarPrototype.default 3833 3836 1:1
TooltipMinimalPerf.default 990 991 1:1
AlertMinimalPerf.default 268 272 0.99:1
CarouselMinimalPerf.default 459 465 0.99:1
ChatWithPopoverPerf.default 355 360 0.99:1
HeaderMinimalPerf.default 352 357 0.99:1
ListNestedPerf.default 539 542 0.99:1
MenuMinimalPerf.default 842 850 0.99:1
SplitButtonMinimalPerf.default 3755 3787 0.99:1
TextMinimalPerf.default 347 351 0.99:1
AccordionMinimalPerf.default 156 160 0.98:1
FlexMinimalPerf.default 284 290 0.98:1
ImageMinimalPerf.default 374 381 0.98:1
RosterPerf.default 1144 1170 0.98:1
TextAreaMinimalPerf.default 498 510 0.98:1
BoxMinimalPerf.default 343 353 0.97:1
HeaderSlotsPerf.default 755 776 0.97:1
RefMinimalPerf.default 233 239 0.97:1
ToolbarMinimalPerf.default 920 945 0.97:1
TreeMinimalPerf.default 790 816 0.97:1
FormMinimalPerf.default 396 418 0.95:1
CardMinimalPerf.default 554 589 0.94:1
TableMinimalPerf.default 391 417 0.94:1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e251133:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@ling1726 ling1726 merged commit 2eef434 into microsoft:master Jul 7, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
Initializes the auto-generated artifacts for the new
`@fluentui/keyboard-keys` package as proposed in microsoft#18587

**Does not publish the package immediately**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants