Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components) fix select style height overlap #18348

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Fixes a visual bug w/ combobox and select styles

Focus areas to test

(optional)

@chrisdholt chrisdholt self-assigned this May 26, 2021
@chrisdholt chrisdholt changed the title Users/chhol/fix select style height overlap (web-components) fix select style height overlap May 26, 2021
@chrisdholt chrisdholt merged commit b013a96 into microsoft:features/web-components-vNext Jun 1, 2021
chrisdholt added a commit that referenced this pull request Jun 8, 2021
* fix a bug where the bottom border for select and comobox would visually disappear on active states

* Change files
chrisdholt added a commit that referenced this pull request Jul 2, 2021
* fix a bug where the bottom border for select and comobox would visually disappear on active states

* Change files
chrisdholt added a commit that referenced this pull request Jul 2, 2021
* fix a bug where the bottom border for select and comobox would visually disappear on active states

* Change files
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
* fix a bug where the bottom border for select and comobox would visually disappear on active states

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants