Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-components] update components to extend foundation element #18187

Merged
merged 36 commits into from
May 14, 2021
Merged

[web-components] update components to extend foundation element #18187

merged 36 commits into from
May 14, 2021

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Updates web components to extend foundation element. This is the first of several steps for our first major version for the Fluent Web Components

Focus areas to test

(optional)

@chrisdholt
update accordion to use foundation element
3c76dd5
@chrisdholt
update anchor to extend foundation element
b39fe2f
@chrisdholt
update anchored region to extend foundation element
1a8323b
@chrisdholt
correct style exports
093f6a3
@chrisdholt
update badge to extend foundation
1d1e031
@chrisdholt
update breadcrumb to extend foundation element
3b05f6b
@chrisdholt
update button to extend foundation element
0882117
@chrisdholt
update checkbox to extend foundation element
42b061d
@chrisdholt
update combobox to extend foundation element
7408822
@chrisdholt
update dialog to extend foundation element
ac0e8ce
@chrisdholt
update divider styles
5fc4bac
@chrisdholt
update flipper to extend foundation element
d46ed4d
@chrisdholt
update horizontal scroll to extend foundation element
7a83214
@chrisdholt
update listbox to extend foundation element
a9cac3b
@chrisdholt
update listbox option to extend foundation element
4961994
@chrisdholt
update naming for exported registries
3fc2c28
@chrisdholt
update menu and menu item to extend foundation
012ca97
@chrisdholt
aupdate number field to extend foundation element
c2574a0
@chrisdholt
update progress to extend foundation element
6716593
@chrisdholt
update radio, radiogroup and select to extend foundation el
3f7fe18
@chrisdholt
update skeleton to extend foundation element
dad0633
@chrisdholt
update slider to extend foundation element
1ce3bb5
@chrisdholt
update switch to extend foundation component
841c936
@chrisdholt
correct prefix for export names
59d8b60
@chrisdholt
update text area to extend foundation element
d19b0df
@chrisdholt
update text field to extend foundation
143e8f3
@chrisdholt
update tooltip to extend foundation element
f5ffe56
@chrisdholt
update tree view to extend foundation element
25bf211
@chrisdholt
update comments v1
29eb86a
@chrisdholt
export all custom element definitions
4869d0e
@chrisdholt chrisdholt self-assigned this May 14, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 14, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 153a408:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

eljefe223
eljefe223 approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@eljefe223 eljefe223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoked, compiles with no errors.

EisenbergEffect
EisenbergEffect approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggestions but otherwise looks good for phase 1.

packages/web-components/src/index-rollup.ts Outdated Show resolved Hide resolved
packages/web-components/src/index-rollup.ts Outdated Show resolved Hide resolved
@chrisdholt chrisdholt force-pushed the users/chhol/update-components-to-extend-foundation-element branch from e3dc4f7 to 153a408 Compare May 14, 2021 17:16
@chrisdholt chrisdholt merged commit ba2809c into microsoft:features/web-components-vNext May 14, 2021
@chrisdholt chrisdholt deleted the users/chhol/update-components-to-extend-foundation-element branch May 14, 2021 17:23
chrisdholt added a commit that referenced this pull request May 14, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
e9439cf 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
chrisdholt added a commit that referenced this pull request May 14, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
6248ad9 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
chrisdholt added a commit that referenced this pull request May 18, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
bc421ef 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
chrisdholt added a commit that referenced this pull request Jun 8, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
43f4029 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
bheston pushed a commit to bheston/fluentui that referenced this pull request Jun 9, 2021
@chrisdholt @bheston
[web-components] update components to extend foundation element (micr…
44e75fd 
…osoft#18187)

* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
bheston pushed a commit to bheston/fluentui that referenced this pull request Jun 9, 2021
@chrisdholt @bheston
[web-components] update components to extend foundation element (micr…
65d6ac4 
…osoft#18187)

* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
bheston pushed a commit to bheston/fluentui that referenced this pull request Jun 14, 2021
@chrisdholt @bheston
[web-components] update components to extend foundation element (micr…
fc2e7aa 
…osoft#18187)

* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
chrisdholt added a commit that referenced this pull request Jul 2, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
ff89874 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
chrisdholt added a commit that referenced this pull request Jul 2, 2021
@chrisdholt
[web-components] update components to extend foundation element (#18187)
aa843ee 
* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@chrisdholt @PeterDraex
[web-components] update components to extend foundation element (micr…
f601729 
…osoft#18187)

* update accordion to use foundation element

* update anchor to extend foundation element

* update anchored region to extend foundation element

* correct style exports

* update badge to extend foundation

* update breadcrumb to extend foundation element

* update button to extend foundation element

* update checkbox to extend foundation element

* update combobox to extend foundation element

* update dialog to extend foundation element

* update divider styles

* update flipper to extend foundation element

* update horizontal scroll to extend foundation element

* update listbox to extend foundation element

* update listbox option to extend foundation element

* update naming for exported registries

* update menu and menu item to extend foundation

* aupdate number field to extend foundation element

* update progress to extend foundation element

* update radio, radiogroup and select to extend foundation el

* update skeleton to extend foundation element

* update slider to extend foundation element

* update switch to extend foundation component

* correct prefix for export names

* update text area to extend foundation element

* update text field to extend foundation

* update tooltip to extend foundation element

* update tree view to extend foundation element

* update comments v1

* export all custom element definitions

* exportfluent design system and definitions from rollup

* add data grid

* update fast to fluent in rollup

* add beta package to start updating w/ foundation element

* update stories files

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljefe223 eljefe223 eljefe223 approved these changes

@awentzel awentzel awentzel approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@scomea scomea Awaiting requested review from scomea

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@Hotell Hotell Awaiting requested review from Hotell

Assignees

@chrisdholt chrisdholt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @EisenbergEffect @nicholasrice @awentzel @eljefe223