[web-components] add combobox as a new component, add filled style for select #17307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
EisenbergEffect,
nicholasrice,
scomea and
eljefe223
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f4f8b4c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8552af0ad666f77e2ba8a3aa3768611d6fed3a5 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
chrisdholt
changed the title
chrisdholt
force-pushed
the
users/chhol/add-combobox-as-new-web-component
branch
from
08faa12
to
5028146
Compare
eljefe223
approved these changes
Mar 7, 2021
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…r select (microsoft#17307) * add combobox as a new web component * Change files * add filled apeparance * update api report and export combobox from root
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…r select (microsoft#17307) * add combobox as a new web component * Change files * add filled apeparance * update api report and export combobox from root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds a new component for "combobox". This change required including filled appearances for select as well in order to implement the appearance as well for combobox.
Focus areas to test
(optional)