Remove hard coded Card background color in favor of Design System paint API #17070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a07a5e1:
|
khamudom
approved these changes
Feb 19, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4011be1f093c7263b7d451bf4b4881e0cc926c85 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
EisenbergEffect
approved these changes
Feb 19, 2021
chrisdholt
deleted the
users/chhol/remove-hard-coded-background-color-in-favor-of-no-paint
branch
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Feb 25, 2021
…nt API (microsoft#17070) * remove hard coded background color in favor of default design system behavior * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This change removes a hard coded background for the color and instead relies on existing API's to draw the background by default with an option to not paint. This may be helpful in scenarios where the context needs to update but the background needs to be handled separately. With the current implementation that's not as easily achieved.
Focus areas to test
(optional)