Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icon only support for anchor and update FAST packages #16248

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5bb3317:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 16, 2020

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
buttonNative mount 108 112 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 874 863 5000
BaseButtonCompat mount 978 965 5000
Breadcrumb mount 42449 42319 5000
Checkbox mount 1628 1612 5000
CheckboxBase mount 1378 1334 5000
ChoiceGroup mount 5075 5018 5000
ComboBox mount 980 981 1000
CommandBar mount 10148 10285 1000
ContextualMenu mount 6148 6251 1000
DefaultButtonCompat mount 1184 1193 5000
DetailsRow mount 3812 3884 5000
DetailsRowFast mount 3796 3849 5000
DetailsRowNoStyles mount 3649 3657 5000
Dialog mount 1501 1477 1000
DocumentCardTitle mount 1798 1784 1000
Dropdown mount 3436 3421 5000
FocusTrapZone mount 1841 1896 5000
FocusZone mount 1879 1866 5000
IconButtonCompat mount 1857 1887 5000
Label mount 334 358 5000
Layer mount 1892 1883 5000
Link mount 481 499 5000
MenuButtonCompat mount 1567 1556 5000
MessageBar mount 2025 1998 5000
Nav mount 3355 3403 1000
OverflowSet mount 1086 1056 5000
Panel mount 1446 1476 1000
Persona mount 883 892 1000
Pivot mount 1458 1498 1000
PrimaryButtonCompat mount 1365 1349 5000
Rating mount 7947 7968 5000
SearchBox mount 1385 1410 5000
Shimmer mount 2683 2748 5000
Slider mount 1937 1966 5000
SpinButton mount 5243 5108 5000
Spinner mount 420 418 5000
SplitButtonCompat mount 3311 3298 5000
Stack mount 522 534 5000
StackWithIntrinsicChildren mount 1576 1587 5000
StackWithTextChildren mount 4793 4840 5000
SwatchColorPicker mount 10605 10592 5000
Tabs mount 1490 1455 1000
TagPicker mount 2963 2971 5000
TeachingBubble mount 11740 11745 5000
Text mount 435 443 5000
TextField mount 1471 1460 5000
ThemeProvider mount 2168 2200 5000
ThemeProvider virtual-rerender 637 650 5000
Toggle mount 813 828 5000
button mount 674 692 5000
buttonNative mount 108 112 5000 Possible regression

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.54 0.89:1 2000 957
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 642
🔧 Checkbox.Fluent 0.67 0.36 1.86:1 1000 670
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 869
🔧 Dropdown.Fluent 3.05 0.44 6.93:1 1000 3053
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 785
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 441
🔧 Slider.Fluent 1.59 0.48 3.31:1 1000 1585
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 419
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 595

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 433 403 1.07:1
SkeletonMinimalPerf.default 482 451 1.07:1
AttachmentMinimalPerf.default 189 179 1.06:1
FlexMinimalPerf.default 355 336 1.06:1
TextMinimalPerf.default 419 397 1.06:1
TooltipMinimalPerf.default 906 854 1.06:1
Text.Fluent 419 397 1.06:1
ButtonMinimalPerf.default 207 197 1.05:1
ButtonUseCssPerf.default 910 863 1.05:1
DialogMinimalPerf.default 870 831 1.05:1
HeaderMinimalPerf.default 445 424 1.05:1
LayoutMinimalPerf.default 462 440 1.05:1
TreeWith60ListItems.default 229 219 1.05:1
Tooltip.Fluent 595 567 1.05:1
AttachmentSlotsPerf.default 1248 1205 1.04:1
ChatMinimalPerf.default 702 674 1.04:1
DividerMinimalPerf.default 427 412 1.04:1
GridMinimalPerf.default 406 390 1.04:1
ImageMinimalPerf.default 461 444 1.04:1
ListWith60ListItems.default 988 954 1.04:1
LoaderMinimalPerf.default 776 743 1.04:1
ProviderMinimalPerf.default 1057 1018 1.04:1
AccordionMinimalPerf.default 186 181 1.03:1
AnimationMinimalPerf.default 448 435 1.03:1
ButtonOverridesMissPerf.default 1786 1730 1.03:1
InputMinimalPerf.default 1390 1347 1.03:1
ItemLayoutMinimalPerf.default 1440 1400 1.03:1
MenuMinimalPerf.default 943 914 1.03:1
RadioGroupMinimalPerf.default 499 485 1.03:1
TextAreaMinimalPerf.default 565 546 1.03:1
Dialog.Fluent 869 840 1.03:1
AlertMinimalPerf.default 346 338 1.02:1
CarouselMinimalPerf.default 497 487 1.02:1
FormMinimalPerf.default 490 482 1.02:1
ListMinimalPerf.default 547 534 1.02:1
PopupMinimalPerf.default 738 727 1.02:1
PortalMinimalPerf.default 167 164 1.02:1
SegmentMinimalPerf.default 417 407 1.02:1
TableMinimalPerf.default 465 455 1.02:1
CustomToolbarPrototype.default 3944 3880 1.02:1
AvatarMinimalPerf.default 511 504 1.01:1
ButtonUseCssNestingPerf.default 1133 1126 1.01:1
ChatDuplicateMessagesPerf.default 447 444 1.01:1
ChatWithPopoverPerf.default 505 499 1.01:1
CheckboxMinimalPerf.default 2994 2972 1.01:1
DatepickerMinimalPerf.default 48880 48470 1.01:1
EmbedMinimalPerf.default 4306 4278 1.01:1
MenuButtonMinimalPerf.default 1706 1684 1.01:1
SplitButtonMinimalPerf.default 3992 3946 1.01:1
TableManyItemsPerf.default 2433 2400 1.01:1
ToolbarMinimalPerf.default 1022 1008 1.01:1
TreeMinimalPerf.default 855 845 1.01:1
VideoMinimalPerf.default 713 703 1.01:1
Button.Fluent 642 635 1.01:1
Dropdown.Fluent 3053 3029 1.01:1
DropdownMinimalPerf.default 3026 3039 1:1
ReactionMinimalPerf.default 468 468 1:1
StatusMinimalPerf.default 815 817 1:1
Icon.Fluent 785 785 1:1
Slider.Fluent 1585 1589 1:1
DropdownManyItemsPerf.default 808 813 0.99:1
ListNestedPerf.default 633 640 0.99:1
Avatar.Fluent 957 969 0.99:1
ButtonSlotsPerf.default 632 647 0.98:1
LabelMinimalPerf.default 469 481 0.98:1
ProviderMergeThemesPerf.default 2061 2093 0.98:1
RefMinimalPerf.default 241 246 0.98:1
SliderMinimalPerf.default 1570 1605 0.98:1
Image.Fluent 441 451 0.98:1
Checkbox.Fluent 670 690 0.97:1
CardMinimalPerf.default 622 650 0.96:1
HeaderSlotsPerf.default 879 914 0.96:1
IconMinimalPerf.default 733 761 0.96:1
ListCommonPerf.default 699 733 0.95:1

@size-auditor
Copy link

size-auditor bot commented Dec 16, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 68c75148ca90ecd3262a0157b13d22c20c460dec (build)

@chrisdholt chrisdholt force-pushed the users/chhol/add-icon-only-anchor-support branch from a71fb3b to 5bb3317 Compare December 17, 2020 00:15
@chrisdholt chrisdholt merged commit cb8c48d into microsoft:master Dec 17, 2020
@chrisdholt chrisdholt deleted the users/chhol/add-icon-only-anchor-support branch December 17, 2020 01:05
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v0.10.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants