Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min-width to be equals to thumb size #14400

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Fix min-width to be equals to thumb size #14400

merged 2 commits into from
Aug 7, 2020

Conversation

uabarahona
Copy link
Contributor

@uabarahona uabarahona commented Aug 7, 2020 •
edited
Loading

Pull request checklist

Description of changes

Changes the min-width to be equals to the size of the thumb, this is a change to keep consistency with the already merged PR microsoft/fast#3640

@ghost
Copy link

ghost commented Aug 7, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@size-auditor
Copy link

size-auditor bot commented Aug 7, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 767e3163956bae62c1e3b5e036badbdc65771d71 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 7, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 880 896 5000
ButtonNext mount 576 590 5000
Checkbox mount 1543 1546 5000
CheckboxBase mount 1317 1271 5000
CheckboxNext mount 1589 1652 5000
ChoiceGroup mount 4940 4926 5000
ComboBox mount 892 897 1000
CommandBar mount 7769 7787 1000
ContextualMenu mount 15315 15287 1000
DefaultButton mount 1102 1097 5000
DetailsRow mount 3515 3515 5000
DetailsRowFast mount 3548 3579 5000
DetailsRowNoStyles mount 3385 3357 5000
Dialog mount 1487 1518 1000
DocumentCardTitle mount 1843 1861 1000
Dropdown mount 2534 2512 5000
FocusZone mount 1871 1820 5000
IconButton mount 1738 1735 5000
Label mount 323 350 5000
Link mount 432 457 5000
LinkNext mount 475 476 5000
MenuButton mount 1460 1455 5000
Nav mount 3257 3249 1000
Panel mount 1447 1463 1000
Persona mount 837 845 1000
Pivot mount 1432 1418 1000
PivotNext mount 1402 1402 1000
PrimaryButton mount 1259 1276 5000
SearchBox mount 1252 1289 5000
SearchBoxNext mount 1330 1317 5000
Slider mount 1504 1469 5000
SliderNext mount 1942 1934 5000
SpinButton mount 4916 4961 5000
SpinButtonNext mount 5081 5075 5000
Spinner mount 443 446 5000
SplitButton mount 3152 3125 5000
Stack mount 520 520 5000
StackWithIntrinsicChildren mount 1951 1962 5000
StackWithTextChildren mount 5068 5014 5000
TagPicker mount 2613 2691 5000
Text mount 433 414 5000
TextField mount 1360 1359 5000
ThemeProvider mount 3048 2892 5000
ThemeProvider virtual-rerender 465 476 5000
Toggle mount 841 842 5000
ToggleNext mount 838 828 5000
button mount 116 120 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.49 0.88:1 2000 869
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 540
🔧 Checkbox.Fluent 0.63 0.32 1.97:1 1000 629
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 765
🔧 Dropdown.Fluent 2.96 0.44 6.73:1 1000 2964
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 688
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 364
🔧 Slider.Fluent 1.59 0.34 4.68:1 1000 1593
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 329
🦄 Tooltip.Fluent 0.11 20.02 0.01:1 5000 528

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 350 322 1.09:1
ButtonMinimalPerf.default 186 172 1.08:1
Button.Fluent 540 498 1.08:1
ImageMinimalPerf.default 364 340 1.07:1
ListNestedPerf.default 896 840 1.07:1
AnimationMinimalPerf.default 393 372 1.06:1
AttachmentMinimalPerf.default 158 151 1.05:1
FlexMinimalPerf.default 276 264 1.05:1
PortalMinimalPerf.default 127 121 1.05:1
ReactionMinimalPerf.default 389 371 1.05:1
SkeletonMinimalPerf.default 394 376 1.05:1
BoxMinimalPerf.default 339 327 1.04:1
ChatDuplicateMessagesPerf.default 420 404 1.04:1
GridMinimalPerf.default 328 315 1.04:1
InputMinimalPerf.default 1305 1252 1.04:1
SegmentMinimalPerf.default 341 329 1.04:1
VideoMinimalPerf.default 617 595 1.04:1
HierarchicalTreeMinimalPerf.default 416 405 1.03:1
TextAreaMinimalPerf.default 445 433 1.03:1
Checkbox.Fluent 629 610 1.03:1
Tooltip.Fluent 528 512 1.03:1
ChatWithPopoverPerf.default 476 466 1.02:1
DialogMinimalPerf.default 767 754 1.02:1
DropdownMinimalPerf.default 2991 2922 1.02:1
HeaderMinimalPerf.default 348 340 1.02:1
ItemLayoutMinimalPerf.default 1244 1218 1.02:1
LayoutMinimalPerf.default 385 377 1.02:1
PopupMinimalPerf.default 674 659 1.02:1
SliderMinimalPerf.default 1622 1591 1.02:1
TableManyItemsPerf.default 2200 2156 1.02:1
TreeWith60ListItems.default 210 205 1.02:1
FormMinimalPerf.default 385 382 1.01:1
LabelMinimalPerf.default 389 386 1.01:1
ListCommonPerf.default 920 911 1.01:1
MenuMinimalPerf.default 841 831 1.01:1
RadioGroupMinimalPerf.default 404 399 1.01:1
SplitButtonMinimalPerf.default 3744 3698 1.01:1
TooltipMinimalPerf.default 767 761 1.01:1
Dropdown.Fluent 2964 2937 1.01:1
Text.Fluent 329 325 1.01:1
AlertMinimalPerf.default 289 288 1:1
ButtonSlotsPerf.default 600 600 1:1
CardMinimalPerf.default 538 538 1:1
CheckboxMinimalPerf.default 2818 2832 1:1
EmbedMinimalPerf.default 1885 1885 1:1
ListMinimalPerf.default 464 465 1:1
MenuButtonMinimalPerf.default 1529 1531 1:1
TextMinimalPerf.default 319 319 1:1
CustomToolbarPrototype.default 3761 3778 1:1
Avatar.Fluent 869 865 1:1
Dialog.Fluent 765 763 1:1
Image.Fluent 364 364 1:1
Slider.Fluent 1593 1589 1:1
CarouselMinimalPerf.default 438 443 0.99:1
ChatMinimalPerf.default 578 581 0.99:1
HeaderSlotsPerf.default 757 767 0.99:1
LoaderMinimalPerf.default 737 742 0.99:1
ProviderMergeThemesPerf.default 1896 1906 0.99:1
ProviderMinimalPerf.default 916 923 0.99:1
RefMinimalPerf.default 213 215 0.99:1
ToolbarMinimalPerf.default 905 918 0.99:1
Icon.Fluent 688 693 0.99:1
AvatarMinimalPerf.default 472 480 0.98:1
DropdownManyItemsPerf.default 741 753 0.98:1
ListWith60ListItems.default 1068 1094 0.98:1
StatusMinimalPerf.default 648 658 0.98:1
TreeMinimalPerf.default 870 888 0.98:1
AccordionMinimalPerf.default 140 146 0.96:1
AttachmentSlotsPerf.default 1115 1158 0.96:1
IconMinimalPerf.default 619 654 0.95:1
TableMinimalPerf.default 383 404 0.95:1

@chrisdholt
Copy link
Member

@barahonajm just an FYI that I'm going to pull your branch down and see if I can't get past this odd build break. Thanks for the contribution here!

@uabarahona
Copy link
Contributor Author

Yes, that will be helpful I was wondering why this was failing, maybe the change on the azure-pipelines.yml 8 hours ago will solve it, I can rebase and try again

@chrisdholt
Copy link
Member

Yes, that will be helpful I was wondering why this was failing, maybe the change on the azure-pipelines.yml 8 hours ago will solve it, I can rebase and try again

@barahonajm If you can try a quick rebase when able that was going to be my first step :)

@uabarahona uabarahona force-pushed the fix_min-width_to_be_equals_to_thumb_size branch from e74fb18 to 5c86236 Compare August 7, 2020 22:38
@uabarahona
Copy link
Contributor Author

Done, hope it works now

@chrisdholt chrisdholt merged commit e0e6494 into microsoft:master Aug 7, 2020
@uabarahona uabarahona deleted the fix_min-width_to_be_equals_to_thumb_size branch August 8, 2020 00:28
@msft-github-bot
Copy link
Contributor

🎉@fluentui/web-components@v0.1.2 has been released which incorporates this pull request.:tada:

Handy links:

tmaster628 pushed a commit to tmaster628/fluentui that referenced this pull request Aug 12, 2020
@uabarahona
Fix min-width to be equals to thumb size (microsoft#14400)
4f22c17 
* Fix min-width to be equals to thumb size

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

Assignees

@khmakoto khmakoto

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uabarahona @msft-github-bot @chrisdholt @khmakoto