Rename @fluentui-react-native/experimental-framework to @fluentui-react-native/framework #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyImChris
approved these changes
Aug 19, 2020
| ['color', ...fontStyles.keys] | ||
| ) | ||
| ['color', ...fontStyles.keys], | ||
| ), |
There was a problem hiding this comment.
Did you run prettier? I see a lot of extraneous commas throughout
There was a problem hiding this comment.
We were getting inconsistency on this setting, after a quick poll in the teams channel we decided to make trailing commas default and I recently updated our general settings to use that. As a result we'll see a bunch of changes like this as people edit files. Long term though it should sort itself out.
I'm tempted to do a full pass but it will generate a lot of noise for people with changes in progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
All changes are impacting experimental packages, so all platforms, but none for production scenarios.
Description of changes
Very soon we want to switch over to using the experimental framework. In preparation for that it is getting a rename to be called @fluentui-react-native/framework. Note that there was a package in the repo with this name but it contained the old framework and was unpublished and unused, it only existed for purposes of running the bundle analyzer.
So this change:
It's just a step in the direction of changing over.
Verification
Automated tests
Pull request checklist
This PR has considered (when applicable):