ContextualMenu A11y Narrator Bug Fix #3905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulnazsayed
changed the title
Saadnajmi
reviewed
Jun 16, 2025
rurikoaraki
approved these changes
Jun 17, 2025
Saadnajmi
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Narrator should announce whether a ContextualMenu SubmenuItem is expanded or collapsed. According to accessibility guidelines, we need to specify
accessibilityActionsandonAccessibilityAction, as well as provide the expanded state inaccessibilityState. To avoid extra overhead in SubmenuItem, I extended fromPressablePropsExtendedinstead ofIPressablePropsto inherit all of the necessary accessibility props and follow the pattern found in other V1 components. Then, provided the default accessibilityActions to be merged with any custom actions the user might pass in.Verification
Manually validated via the FURN tester that narrator announces the expanded/collapsed state of a nested submenu item when focused.
Pull request checklist
This PR has considered (when applicable):