chore: Update to React Native 0.74#3784
Closed
Saadnajmi wants to merge 5 commits intomicrosoft:mainfrom
Closed
Conversation
tido64
reviewed
Oct 9, 2024
Comment on lines
42
to
43
| "@office-iss/react-native-win32": "^0.73.0", | ||
| "@office-iss/rex-win32": "0.73.11-devmain.16.0.17614.15010", |
Member
There was a problem hiding this comment.
Should all the win32 packages also be bumped?
Collaborator
There was a problem hiding this comment.
FYI @Saadnajmi @office-iss/rex-win32 hasn't published a new version in a year. I think it used to depend on some variable/pipeline that has now been discontinued.
tido64
reviewed
Oct 9, 2024
| @@ -5739,7 +5943,7 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "@react-native-community/cli-platform-ios@npm:12.3.7, @react-native-community/cli-platform-ios@npm:^12.1.1": | |||
| "@react-native-community/cli-platform-ios@npm:12.3.7": | |||
Member
There was a problem hiding this comment.
There are some old packages in here still. Probably because of the win32 packages.
tido64
reviewed
Oct 9, 2024
Member
There was a problem hiding this comment.
Shouldn't there be a diff for ios/Podfile.lock as well?
Collaborator
|
going to close this since we got #3896 done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Run rnx-align-deps with the 0.74 requirement and fix as many warnings as we can.
Verification
Pull request checklist
This PR has considered (when applicable):