Update react-native-svg to 12.4.0 #1940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@rurikoaraki for context (since you touched this last), RN-SVG doesn't properly support DynamicColorIOS until 12.4.0 where this PR landed. This caused a Redbox in Notification, which uses DynamicColorIOS while we don't have design tokens. |
Collaborator
|
It's not working on RNW atm jsyk. It was another spinning plate that I dropped 😓 |
Contributor
Author
|
Closing in favor of #1856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Updated react-native-svg to from 12.3.0 to 12.4.0. This unblocks Notification.
Pull request checklist
This PR has considered (when applicable):