Skip to content

Callout macOS #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 92 commits into from
Nov 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
20f48c7
Copy Polyester Callout
Saadnajmi May 25, 2021
d476ac8
WIP Callout
Saadnajmi May 25, 2021
0f3d72f
WIP
Saadnajmi May 26, 2021
d3ccc10
More callout props work
Saadnajmi May 27, 2021
e44ef61
Update var name
Saadnajmi May 28, 2021
cfcd2b3
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Jun 28, 2021
4dbb54d
Fix stuff
Saadnajmi Jun 28, 2021
eb40ad3
More small fixes
Saadnajmi Jun 28, 2021
e79798d
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Jul 2, 2021
d6a3bf4
We have a contextmenu rendering
Saadnajmi Jul 2, 2021
a54c22c
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Jul 16, 2021
c994410
initial commit
Saadnajmi Sep 23, 2021
33f2f99
wip
Saadnajmi Sep 25, 2021
5c65ab6
menu pops up at right place
Saadnajmi Sep 27, 2021
95035a0
tryna get custom views
Saadnajmi Sep 28, 2021
6536207
onDismiss callback works
Saadnajmi Sep 28, 2021
e717c72
onShow event
Saadnajmi Sep 28, 2021
c146727
Extract props from children
Saadnajmi Sep 29, 2021
faf4c8e
wip on custom views
Saadnajmi Sep 29, 2021
3d04ee7
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Sep 29, 2021
ad0e070
update to latest
Saadnajmi Sep 29, 2021
6185085
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Sep 30, 2021
86ed4a2
Small fixes
Saadnajmi Sep 30, 2021
e90097c
get focus ring
Saadnajmi Sep 30, 2021
11bb9e6
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Sep 30, 2021
54b7ac0
wip
Saadnajmi Oct 1, 2021
51a8353
Custom views work now
Saadnajmi Oct 2, 2021
0a7511b
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 5, 2021
5a921c6
update podfile
Saadnajmi Oct 5, 2021
4b4887c
wip
Saadnajmi Oct 7, 2021
21103ed
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 7, 2021
3f8455a
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 8, 2021
25fc93c
custom view layout works
Saadnajmi Oct 8, 2021
6fa1673
remove unnecessary references
Saadnajmi Oct 8, 2021
4587f2d
remove more test code
Saadnajmi Oct 8, 2021
48e545c
Clean up code
Saadnajmi Oct 8, 2021
6675359
Add a touch handler, yet hover effects still don't work
Saadnajmi Oct 8, 2021
a1201ee
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 8, 2021
137b5a7
Merge branch 'callout' of github.com:Saadnajmi/fluentui-react-native …
Saadnajmi Oct 8, 2021
44d679f
reduce diffs
Saadnajmi Oct 8, 2021
7566ee5
Pull in changes from menu-macos branch
Saadnajmi Oct 8, 2021
d48e0f2
tabs
Saadnajmi Oct 8, 2021
e41ce8c
fix indents
Saadnajmi Oct 8, 2021
5650a54
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 18, 2021
cd51002
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 18, 2021
68bce7f
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 25, 2021
f8bc234
update podfile
Saadnajmi Oct 25, 2021
0a23339
update podfile
Saadnajmi Oct 25, 2021
b43cc17
Fix typo
Saadnajmi Oct 25, 2021
599bb1e
fix indentation and typo
Saadnajmi Oct 25, 2021
cde93e8
Refactor updateCalloutFrameToTargetFrame
Saadnajmi Oct 25, 2021
c6c9f02
refactor getting screenFrame
Saadnajmi Oct 25, 2021
de3cb10
wip
Saadnajmi Oct 25, 2021
f40db4a
remove anchorRect support for now
Saadnajmi Oct 25, 2021
aba5b39
Rewrote most of Callout
Saadnajmi Oct 26, 2021
b839ec2
anchor rects almost work. Boo flipped coordinates
Saadnajmi Oct 26, 2021
5c81dfe
Delete iOS PLY code
Saadnajmi Oct 26, 2021
4331d28
update inline documentation
Saadnajmi Oct 26, 2021
a5ec19b
clean up for the day
Saadnajmi Oct 26, 2021
b8be475
undo stuff
Saadnajmi Oct 26, 2021
7903f3d
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 26, 2021
2a536f9
Release window when closed
Saadnajmi Oct 27, 2021
7844f0e
directional hints wip
Saadnajmi Oct 27, 2021
6ee8577
Fixed bug with flipped Y coordinates in anchorRect, + directional hin…
Saadnajmi Oct 27, 2021
ce8ea9a
temporary workaround to get hover back
Saadnajmi Oct 27, 2021
4758a80
Update comment
Saadnajmi Oct 27, 2021
9678a88
More cleanup
Saadnajmi Oct 28, 2021
d90d1e5
Fix alignment issues
Saadnajmi Oct 28, 2021
4e4afdf
Change files
Saadnajmi Oct 28, 2021
74a4a3b
Update snapshots
Saadnajmi Oct 28, 2021
4201052
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 29, 2021
619650e
Fix some nits
Saadnajmi Oct 29, 2021
e6c4eb0
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Oct 29, 2021
cc1ac55
Fix hover
Saadnajmi Oct 29, 2021
59bddd5
remove unnecessary breaks
Saadnajmi Oct 29, 2021
02ec7be
Fix some indentation
Saadnajmi Oct 29, 2021
0b76863
fox more tabs, alphabetize list
Saadnajmi Oct 29, 2021
a734b61
remove unnecessary import
Saadnajmi Oct 29, 2021
f1771bb
Don't need to remove observor
Saadnajmi Oct 29, 2021
175ed12
Move styling off of apple theme into macos specific files
Saadnajmi Oct 29, 2021
897bcb0
undo change in win32 settings
Saadnajmi Oct 29, 2021
b313265
smaller diff
Saadnajmi Oct 29, 2021
f96194b
remove unnecessary import
Saadnajmi Oct 29, 2021
c06d6ed
update deps
Saadnajmi Oct 29, 2021
d17b982
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Nov 3, 2021
1ca5082
Add back dependency to Callout
Saadnajmi Nov 3, 2021
e169d93
Fix test
Saadnajmi Nov 3, 2021
b3f1e16
update podfile lock
Saadnajmi Nov 3, 2021
522c43b
Get corner Radius on Callout working
Saadnajmi Nov 3, 2021
89cbc0e
Fix review feedback
Saadnajmi Nov 3, 2021
a0f4436
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
Saadnajmi Nov 3, 2021
febb0a7
IViewProps from adapters breaks web bundle for some reason
Saadnajmi Nov 3, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-var-requires */
import * as React from 'react';
import { Text, View, Switch } from 'react-native';
import { Text, View, Switch, Platform } from 'react-native';
import {
Text as FURNText,
Button,
Expand Down Expand Up @@ -118,12 +118,19 @@ const nestedContextualMenu: React.FunctionComponent = () => {
const testImage = require('../Button/icon_24x24.png');
const testTtf = require('../Button/Font Awesome 5 Free-Solid-900.otf');

const fontProps: FontIconProps = {
fontFamily: `Font Awesome 5 Free`,
fontSrcFile: testTtf,
codepoint: 0xf083,
fontSize: 16,
};
const fontProps: FontIconProps = Platform.select({
macos: {
fontFamily: 'Arial',
codepoint: 0x2663,
fontSize: 32,
},
default: {
fontFamily: `Font Awesome 5 Free`,
fontSrcFile: testTtf,
codepoint: 0xf083,
fontSize: 32,
},
});

const svgProps: SvgIconProps = {
src: TestSvg,
Expand Down Expand Up @@ -335,6 +342,7 @@ const IconContextualMenu: React.FunctionComponent = () => {
</View>
);
};

const contextualMenuSections: TestSection[] = [
{
name: 'Standard ContextualMenu',
Expand Down
108 changes: 63 additions & 45 deletions apps/fluent-tester/src/FluentTester/testPages.macos.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { TestDescription } from './TestComponents';
import { AvatarTest, HOMEPAGE_AVATAR_BUTTON } from './TestComponents/Avatar';
import { ButtonTest, HOMEPAGE_BUTTON_BUTTON } from './TestComponents/Button';
import { CalloutTest, HOMEPAGE_CALLOUT_BUTTON } from './TestComponents/Callout';
import { CheckboxTest, HOMEPAGE_CHECKBOX_BUTTON } from './TestComponents/Checkbox';
import { ContextualMenuTest, HOMEPAGE_CONTEXTUALMENU_BUTTON } from './TestComponents/ContextualMenu';
import { ExperimentalCheckboxTest, HOMEPAGE_CHECKBOX_CHECKBOXEXPERIMENTAL } from './TestComponents/CheckboxExperimental';
import { ExperimentalButtonTest, HOMEPAGE_BUTTON_BUTTONEXPERIMENTAL } from './TestComponents/ButtonExperimental';
import { HOMEPAGE_FOCUSZONE_BUTTON, FocusZoneTest } from './TestComponents/FocusZone';
Expand All @@ -21,6 +23,7 @@ import { HOMEPAGE_TOKEN_BUTTON, TokenTest } from './TestComponents/Tokens';
import { HOMEPAGE_TABS_BUTTON, TabsTest } from './TestComponents/Tabs';
import { HOMEPAGE_EXPERIMENTAL_TABS_BUTTON, ExperimentalTabsTest } from './TestComponents/TabsExperimental';
import { HOMEPAGE_EXPERIMENTAL_TEXT_BUTTON, TextExperimentalTest } from './TestComponents/TextExperimental';
import { ExperimentalMenuButtonTest, HOMEPAGE_MENU_BUTTON_EXPERIMENTAL } from './TestComponents/MenuButtonExperimental';

export const tests: TestDescription[] = [
{
Expand All @@ -33,20 +36,55 @@ export const tests: TestDescription[] = [
component: ButtonTest,
testPage: HOMEPAGE_BUTTON_BUTTON,
},
{
name: 'Callout Test',
component: CalloutTest,
testPage: HOMEPAGE_CALLOUT_BUTTON,
},
{
name: 'Checkbox Test',
component: CheckboxTest,
testPage: HOMEPAGE_CHECKBOX_BUTTON,
},
{
name: 'ContextualMenu Test',
component: ContextualMenuTest,
testPage: HOMEPAGE_CONTEXTUALMENU_BUTTON,
},
{
name: 'Experimental Button',
component: ExperimentalButtonTest,
testPage: HOMEPAGE_BUTTON_BUTTONEXPERIMENTAL,
},
{
name: 'Experimental Checkbox',
component: ExperimentalCheckboxTest,
testPage: HOMEPAGE_CHECKBOX_CHECKBOXEXPERIMENTAL,
},
{
name: 'Experimental MenuButton Test',
component: ExperimentalMenuButtonTest,
testPage: HOMEPAGE_MENU_BUTTON_EXPERIMENTAL,
},
{
name: 'Experimental Tabs Test',
component: ExperimentalTabsTest,
testPage: HOMEPAGE_EXPERIMENTAL_TABS_BUTTON,
},
{
name: 'Experimental Text Test',
component: TextExperimentalTest,
testPage: HOMEPAGE_EXPERIMENTAL_TEXT_BUTTON,
},
{
name: 'FocusZone Test',
component: FocusZoneTest,
testPage: HOMEPAGE_FOCUSZONE_BUTTON,
},
{
name: 'Pressable Test',
component: PressableTest,
testPage: HOMEPAGE_PRESSABLE_BUTTON,
name: 'Icon Test',
component: IconTest,
testPage: HOMEPAGE_ICON_BUTTON,
},
{
name: 'Link Test',
Expand All @@ -59,74 +97,54 @@ export const tests: TestDescription[] = [
testPage: HOMEPAGE_MENU_BUTTON,
},
{
name: 'Separator Test',
component: SeparatorTest,
testPage: HOMEPAGE_SEPARATOR_BUTTON,
},
{
name: 'Text Test',
component: TextTest,
testPage: HOMEPAGE_TEXT_BUTTON,
},
{
name: 'Experimental Text Test',
component: TextExperimentalTest,
testPage: HOMEPAGE_EXPERIMENTAL_TEXT_BUTTON,
},
{
name: 'Shimmer Test',
component: ShimmerTest,
testPage: HOMEPAGE_SHIMMER_BUTTON,
},
{
name: 'Theme Test',
component: ThemeTest,
testPage: HOMEPAGE_THEME_BUTTON,
name: 'Persona Test',
component: PersonaTest,
testPage: HOMEPAGE_PERSONA_BUTTON,
},
{
name: 'PersonaCoin Test',
component: PersonaCoinTest,
testPage: HOMEPAGE_PERSONACOIN_BUTTON,
},
{
name: 'Pressable Test',
component: PressableTest,
testPage: HOMEPAGE_PRESSABLE_BUTTON,
},
{
name: 'RadioGroup Test',
component: RadioGroupTest,
testPage: HOMEPAGE_RADIOGROUP_BUTTON,
},
{
name: 'Persona Test',
component: PersonaTest,
testPage: HOMEPAGE_PERSONA_BUTTON,
},
{
name: 'Checkbox Test',
component: CheckboxTest,
testPage: HOMEPAGE_CHECKBOX_BUTTON,
name: 'Separator Test',
component: SeparatorTest,
testPage: HOMEPAGE_SEPARATOR_BUTTON,
},
{
name: 'Experimental Checkbox',
component: ExperimentalCheckboxTest,
testPage: HOMEPAGE_CHECKBOX_CHECKBOXEXPERIMENTAL,
name: 'Shimmer Test',
component: ShimmerTest,
testPage: HOMEPAGE_SHIMMER_BUTTON,
},
{
name: 'Svg Test',
component: SvgTest,
testPage: HOMEPAGE_SVG_BUTTON,
},
{
name: 'Icon Test',
component: IconTest,
testPage: HOMEPAGE_ICON_BUTTON,
},
{
name: 'Tabs Test',
component: TabsTest,
testPage: HOMEPAGE_TABS_BUTTON,
},
{
name: 'Experimental Tabs Test',
component: ExperimentalTabsTest,
testPage: HOMEPAGE_EXPERIMENTAL_TABS_BUTTON,
name: 'Text Test',
component: TextTest,
testPage: HOMEPAGE_TEXT_BUTTON,
},
{
name: 'Theme Test',
component: ThemeTest,
testPage: HOMEPAGE_THEME_BUTTON,
},
{
name: 'Tokens Test',
Expand Down
1 change: 1 addition & 0 deletions apps/macos/src/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ use_test_app! do |target|
target.app do
platform :osx, '10.14'
pod 'FRNAvatar', :path => '../../../packages/experimental/Avatar/FRNAvatar.podspec'
pod 'FRNCallout', :path => '../../../packages/components/Callout/FRNCallout.podspec'
pod 'FRNCheckbox', :path => '../../../packages/experimental/Checkbox/FRNCheckbox.podspec'
pod 'FRNMenuButton', :path => '../../../packages/components/MenuButton/FRNMenuButton.podspec'
pod 'FRNRadioButton', :path => '../../../packages/components/RadioGroup/FRNRadioButton.podspec'
Expand Down
28 changes: 17 additions & 11 deletions apps/macos/src/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,17 @@ PODS:
- React-Core (= 0.63.41)
- React-jsi (= 0.63.41)
- ReactCommon/turbomodule/core (= 0.63.41)
- FRNAvatar (0.12.16):
- FRNAvatar (0.12.17):
- MicrosoftFluentUI (= 0.3.0)
- MicrosoftFluentUI/Avatar_ios (= 0.3.0)
- React
- FRNCheckbox (0.2.8):
- FRNCallout (0.17.29):
- React
- FRNMenuButton (0.6.15):
- FRNCheckbox (0.3.0):
- React
- FRNRadioButton (0.13.16):
- FRNMenuButton (0.6.16):
- React
- FRNRadioButton (0.13.17):
- React
- glog (0.3.5)
- MicrosoftFluentUI (0.3.0):
Expand Down Expand Up @@ -92,7 +94,7 @@ PODS:
- boost-for-react-native
- DoubleConversion
- glog
- RCTFocusZone (0.7.31):
- RCTFocusZone (0.7.32):
- React
- RCTRequired (0.63.41)
- RCTTypeSafety (0.63.41):
Expand Down Expand Up @@ -335,6 +337,7 @@ DEPENDENCIES:
- FBLazyVector (from `../../../node_modules/react-native-macos/Libraries/FBLazyVector`)
- FBReactNativeSpec (from `../../../node_modules/react-native-macos/Libraries/FBReactNativeSpec`)
- FRNAvatar (from `../../../packages/experimental/Avatar/FRNAvatar.podspec`)
- FRNCallout (from `../../../packages/components/Callout/FRNCallout.podspec`)
- FRNCheckbox (from `../../../packages/experimental/Checkbox/FRNCheckbox.podspec`)
- FRNMenuButton (from `../../../packages/components/MenuButton/FRNMenuButton.podspec`)
- FRNRadioButton (from `../../../packages/components/RadioGroup/FRNRadioButton.podspec`)
Expand Down Expand Up @@ -386,6 +389,8 @@ EXTERNAL SOURCES:
:path: "../../../node_modules/react-native-macos/Libraries/FBReactNativeSpec"
FRNAvatar:
:path: "../../../packages/experimental/Avatar/FRNAvatar.podspec"
FRNCallout:
:path: "../../../packages/components/Callout/FRNCallout.podspec"
FRNCheckbox:
:path: "../../../packages/experimental/Checkbox/FRNCheckbox.podspec"
FRNMenuButton:
Expand Down Expand Up @@ -454,14 +459,15 @@ SPEC CHECKSUMS:
DoubleConversion: 56a44bcfd14ab2ff66f5a146b2e875eb4b69b19b
FBLazyVector: 9dde2e0340ba783233dba7c6b77e65889047fbb3
FBReactNativeSpec: 6088d5ab01851853cc3fc5384d3f5edf7c898e54
FRNAvatar: 0a882f889ab15c18320d23eb8928defb271c6bb7
FRNCheckbox: ebe46ef9b42b147b29c964090f050191ff4a8bfe
FRNMenuButton: cac2099d2ab79eaa882d4fcbc09dc625d81124d3
FRNRadioButton: 53dcd1d4e56c8be451a10aaf3348e206aa75c2ef
FRNAvatar: aae0394c67f2cc2863652c35ea97e27ca9d8e6db
FRNCallout: 678bf506e75151b7f8e1f1de6e01b2151cea78a5
FRNCheckbox: ee580a9d12aa96d454486138056cbdf72473978b
FRNMenuButton: 8d2594051a0d4ab3423a8cff55bf2a30cff62b28
FRNRadioButton: ed4fc4620d358f8fbf703b712132d93a89a41140
glog: 1cb7c408c781ae8f35bbababe459b45e3dee4ec1
MicrosoftFluentUI: b98d877a2122804132365aa167944f58ef4adb69
RCT-Folly: 1347093ffe75e152d846f7e45a3ef901b60021aa
RCTFocusZone: d2ce4dedfce3371e718a1cac509e20ec6a95bf61
RCTFocusZone: 848540e920f453e0838d64237c7317a8565db0e1
RCTRequired: 64eedb6cf5f0ae7d4c3925e0b9a87747d0391735
RCTTypeSafety: a8ce68a3ce4aa22cd6a9cbf09607ad2b016b51d5
React: a8f98b76204f8a85b22311e8fe145b7bbe5b80e5
Expand Down Expand Up @@ -489,6 +495,6 @@ SPEC CHECKSUMS:
SwiftLint: 99f82d07b837b942dd563c668de129a03fc3fb52
Yoga: 6a194db2cebcae86e56caf702b8c659f5c0da133

PODFILE CHECKSUM: b54fe60c3ce918d2e858b86629d2094398e73914
PODFILE CHECKSUM: af0f113e908b05f6bdf16aee336bceb3613a72cf

COCOAPODS: 1.11.2
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix typo on click",
"packageName": "@fluentui-react-native/apple-theme",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Added macOS support",
"packageName": "@fluentui-react-native/callout",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Beta macOS support",
"packageName": "@fluentui-react-native/contextual-menu",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fixing capitalization in some of the native code for macOS",
"packageName": "@fluentui-react-native/menu-button",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Added macOS Callout and ContextualMenu tests",
"packageName": "@fluentui-react-native/tester",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions package.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

<!-- macOS ship -->
<file src="DerivedData\Build\Products\Release\FRNAvatar\libFRNAvatar.a" target="Ship-macosx"/>
<file src="DerivedData\Build\Products\Release\FRNMenuButton\libFRNCallout.a" target="Ship-macosx"/>
<file src="DerivedData\Build\Products\Release\FRNCheckbox\libFRNCheckbox.a" target="Ship-macosx"/>
<file src="DerivedData\Build\Products\Release\FRNMenuButton\libFRNMenuButton.a" target="Ship-macosx"/>
<file src="DerivedData\Build\Products\Release\FRNRadioButton\libFRNRadioButton.a" target="Ship-macosx"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require 'json'
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

Pod::Spec.new do |s|
s.name = 'FRNRadioButton'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused on this change. You're renaming radio button to be a callout?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think git got confused here, I'm making a new file but git thinks I'm renaming the old one. I'll see if I can make that go away

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so what happened is this PR is so old it was back when we still had a separate NativeRadioButton package (instead of just having it in the same radio button package), and while I was working on it that package (and it's podspec) got deleted. Git interpreted that as me renaming the podspec.

s.name = 'FRNCallout'
s.version = package['version']
s.summary = package['description']
s.license = package['license']
Expand Down
Loading