-
Notifications
You must be signed in to change notification settings - Fork 162
Callout macOS #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callout macOS #1100
Changes from all commits
20f48c7
d476ac8
0f3d72f
d3ccc10
e44ef61
cfcd2b3
4dbb54d
eb40ad3
e79798d
d6a3bf4
a54c22c
c994410
33f2f99
5c65ab6
95035a0
6536207
e717c72
c146727
faf4c8e
3d04ee7
ad0e070
6185085
86ed4a2
e90097c
11bb9e6
54b7ac0
51a8353
0a7511b
5a921c6
4b4887c
21103ed
3f8455a
25fc93c
6fa1673
4587f2d
48e545c
6675359
a1201ee
137b5a7
44d679f
7566ee5
d48e0f2
e41ce8c
5650a54
cd51002
68bce7f
f8bc234
0a23339
b43cc17
599bb1e
cde93e8
c6c9f02
de3cb10
f40db4a
aba5b39
b839ec2
5c81dfe
4331d28
a5ec19b
b8be475
7903f3d
2a536f9
7844f0e
6ee8577
ce8ea9a
4758a80
9678a88
d90d1e5
4e4afdf
74a4a3b
4201052
619650e
e6c4eb0
cc1ac55
59bddd5
02ec7be
0b76863
a734b61
f1771bb
175ed12
897bcb0
b313265
f96194b
c06d6ed
d17b982
1ca5082
e169d93
b3f1e16
522c43b
89cbc0e
a0f4436
febb0a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "fix typo on click", | ||
"packageName": "@fluentui-react-native/apple-theme", | ||
"email": "sanajmi@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Added macOS support", | ||
"packageName": "@fluentui-react-native/callout", | ||
"email": "sanajmi@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Beta macOS support", | ||
"packageName": "@fluentui-react-native/contextual-menu", | ||
"email": "sanajmi@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "fixing capitalization in some of the native code for macOS", | ||
"packageName": "@fluentui-react-native/menu-button", | ||
"email": "sanajmi@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Added macOS Callout and ContextualMenu tests", | ||
"packageName": "@fluentui-react-native/tester", | ||
"email": "sanajmi@microsoft.com", | ||
"dependentChangeType": "patch" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ require 'json' | |
package = JSON.parse(File.read(File.join(__dir__, 'package.json'))) | ||
|
||
Pod::Spec.new do |s| | ||
s.name = 'FRNRadioButton' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a bit confused on this change. You're renaming radio button to be a callout? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think git got confused here, I'm making a new file but git thinks I'm renaming the old one. I'll see if I can make that go away There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah so what happened is this PR is so old it was back when we still had a separate NativeRadioButton package (instead of just having it in the same radio button package), and while I was working on it that package (and it's podspec) got deleted. Git interpreted that as me renaming the podspec. |
||
s.name = 'FRNCallout' | ||
s.version = package['version'] | ||
s.summary = package['description'] | ||
s.license = package['license'] | ||
|
Uh oh!
There was an error while loading. Please reload this page.