refactor: Optimize string handling capabilities #615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnbaaij
previously approved these changes
Aug 15, 2023
vnbaaij
requested changes
Aug 15, 2023
Collaborator
vnbaaij
left a comment
vnbaaij
left a comment
There was a problem hiding this comment.
Please target new-components branch for this.
Also, are you sure there re no changes because of going from nullable string? to non-nullable StringBuilder
Contributor
Author
Okay, I will do it tomorrow.
I think I make sure that StringBuilder will never be NULL. I will think it over. Good night💤 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Optimize performance by changing
stringtoStringBuilderdue to extensive string concatenation.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific