Remove the outer div and the max-height, max-width parameters in fluent-listbox #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnbaaij
approved these changes
Aug 14, 2023
vnbaaij
added a commit
that referenced
this pull request
Aug 14, 2023
* Update banner * Update to web-components.min.js v2.5.16 and update/extend relevant examples. Update version (2.4.2) * Update to web-components.min.js v2.5.16 and update/extend relevant examples. (#579) Update version (2.4.2) * Update version on index page Update example * Add version number to web components script * Update WhatsNew docs * Change version banner * fix: Remove the outer div and the max-height, max-width parameters. (#605) Co-authored-by: Vincent Baaij <vnbaaij@outlook.com> --------- Co-authored-by: Yue Cui <37979368+LuohuaRain@users.noreply.github.com>
Closed
vnbaaij
added a commit
that referenced
this pull request
Aug 25, 2023
* Update banner * Update to web-components.min.js v2.5.16 and update/extend relevant examples. (#579) * Update version (2.4.2) * Update version on index page * Update example * Add version number to web components script * Update WhatsNew docs * Change version banner * fix: Remove the outer div and the max-height, max-width parameters. (#605) Co-authored-by: Vincent Baaij <vnbaaij@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
I believe there is no need to use an additional div to control the width and height. Because we already have
Styleparameter.ref: https://github.com/microsoft/fast/blob/master/packages/web-components/fast-foundation/src/listbox/listbox.template.ts
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps