Skip to content

NavMenu not deselecting initial link for deep-linked urls #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 5 commits into from
Jul 18, 2023
Merged

NavMenu not deselecting initial link for deep-linked urls #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9bc5d4
Add SetSelectedAsync
mrpmorris Jul 13, 2023
7b9dd34
Merge from upstream
mrpmorris Jul 17, 2023
8f253a1
Merge branch 'new-components' of https://github.com/microsoft/fluentu…
mrpmorris Jul 18, 2023
37f9e3a
Ensure previous NavMenu elements are deselected
mrpmorris Jul 18, 2023
4e8afbd
Merge branch 'new-components' into 559/PeteM-NavMenuNotDeselectingIni…
vnbaaij Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/Components/TreeView/FluentTreeItem.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ internal async Task SetSelectedAsync(bool value)
Selected = value;
if (SelectedChanged.HasDelegate)
{
await SelectedChanged.InvokeAsync(value);
await SelectedChanged.InvokeAsync(Selected);
}
}

Expand Down
9 changes: 8 additions & 1 deletion src/Core/Components/TreeView/FluentTreeView.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,18 @@ private async Task HandleCurrentSelectedChangeAsync(TreeChangeEventArgs args)
}

var previouslySelected = CurrentSelected;
await _currentSelectedChangedDebouncer.DebounceAsync(100,() => InvokeAsync(async () =>
await _currentSelectedChangedDebouncer.DebounceAsync(100, () => InvokeAsync(async () =>
{
CurrentSelected = treeItem?.Selected == true ? treeItem : null;
if (CurrentSelected != previouslySelected && CurrentSelectedChanged.HasDelegate)
{
foreach(FluentTreeItem item in _allItems.Values)
{
if (item != CurrentSelected && item.Selected)
{
await item.SetSelectedAsync(false);
}
}
await CurrentSelectedChanged.InvokeAsync(CurrentSelected);
}
}));
Expand Down