[dev-v5][Input] Make sure label is created at the right location#5038
Draft
vnbaaij wants to merge 1 commit into
Draft
[dev-v5][Input] Make sure label is created at the right location#5038vnbaaij wants to merge 1 commit into
vnbaaij wants to merge 1 commit into
Conversation
Unit Tests
Details on your Workflow / Core Tests page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is an initial attempt to address #4980 by changing how FluentTextInput emits its label so the rendered structure can align better with Fluent UI Web Components and improve accessible-name computation.
Changes:
- Renders
Labelcontent inside the<fluent-text-input>element.
| </div> | ||
| } | ||
|
|
||
| @Label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4980
We need to re-evaluate how to render the label on input components. We are deviating from how it is done in the standard web components and that's causing a11y issues.
This is only a first stab at solving this. It is not complete and unit tests have not been created/altered.
We can use https://stackblitz.com/edit/typescript-juzjvyeg?file=index.html for seeing how it works on the WC side
This must be released before go-live