-
Notifications
You must be signed in to change notification settings - Fork 458
[Menu] Fix dispose error #4256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Menu] Fix dispose error #4256
Conversation
|
I will try this fix locally on my machine. |
Yes, please! Based on the error, this seems to me the logical thing to check. If not, we need to go back to the drawing board... |
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
|
@vnbaaij can you tell me how I can build a local nupgk file for testing? Setting doesn't do the trick for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the error is ObjectDisposedException adding null checks wont help. We either need to to supply a _disposed bool or set the modules to null after disposing them.
Also maybe we should pass a CancellationToken in the InvokeAsync methods so we can cancel the CTS in the DisposeAsync method just to be safe.
|
@vnbaaij I can confirm this doesn't fix the issue. I believe the main cause of this is that the |
|
Why did this get merged? I'm confused. |
|
I had turned on auto merge... |
You can just right click the project in the Solution Explorer and choose 'Pack'. It will create a NuGet package in the 'artifacts' folder, using the version number set in the |

Fix #4248
Extra null checks added