[Combobox] Fix presetting option #4255

vnbaaij · 2025-10-21T08:42:41Z

Fix #4250 by extending the GetOptionSelected code

github-actions · 2025-10-21T08:46:44Z

✅ All tests passed successfully

Details on your Workflow / Core Tests page.

github-actions · 2025-10-21T08:47:12Z

Summary - Unit Tests Code Coverage

Summary


Generated on:	10/22/2025 - 11:40:54 AM
Coverage date:	10/22/2025 - 11:40:43 AM
Parser:	Cobertura
Assemblies:	1
Classes:	255
Files:	365
Line coverage:	61.2% (6213 of 10147)
Covered lines:	6213
Uncovered lines:	3934
Coverable lines:	10147
Total lines:	34161
Branch coverage:	53.1% (3132 of 5893)
Covered branches:	3132
Total branches:	5893
Method coverage:	Feature is only available for sponsors
Tag:	4483_18714916715

Coverage

Microsoft.FluentUI.AspNetCore.Components - 61.2%

Name	Line	Branch
Microsoft.FluentUI.AspNetCore.Components	61.2%	53.1%
Microsoft.FluentUI.AspNetCore.Components.AccordionChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.ActionButton`1	50%
Microsoft.FluentUI.AspNetCore.Components.ActionLink`1	0%
Microsoft.FluentUI.AspNetCore.Components.CalendarExtended	95%	86.6%
Microsoft.FluentUI.AspNetCore.Components.CalendarTitles	87%	76.6%
Microsoft.FluentUI.AspNetCore.Components.CheckboxChangeEventArgs	50%
Microsoft.FluentUI.AspNetCore.Components.ColumnBase`1	25.8%	20.8%
Microsoft.FluentUI.AspNetCore.Components.ColumnKeyGridSort`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ColumnOptionsLabels	80%
Microsoft.FluentUI.AspNetCore.Components.ColumnResizeLabels	90.9%
Microsoft.FluentUI.AspNetCore.Components.ColumnResizeOptions`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ColumnSortLabels	85.7%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CommunicationToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.ComponentParameters	16.6%	0%
Microsoft.FluentUI.AspNetCore.Components.Components.DateTime.RangeOfDates	100%	50%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipGlobalOp tions	40%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipOptions	0%
Microsoft.FluentUI.AspNetCore.Components.Components.Tooltip.TooltipService	57.5%	30%
Microsoft.FluentUI.AspNetCore.Components.ConfirmationToast	0%
Microsoft.FluentUI.AspNetCore.Components.CountdownTimer	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CustomEmoji	0%	0%
Microsoft.FluentUI.AspNetCore.Components.CustomIcon	0%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.AsyncQuery ExecutorSupplier	38.4%	43.7%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.ColumnsCol lectedNotifier`1	87.5%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.Defer	100%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.DisplayAtt ributeExtensions	66.6%	50%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGr idContext`1	90.4%	100%
Microsoft.FluentUI.AspNetCore.Components.DataGridCellFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DataGridRowFocusEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.DialogHelper	0%
Microsoft.FluentUI.AspNetCore.Components.DialogInstance	86.6%	75%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters	91.1%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogParameters`1	100%
Microsoft.FluentUI.AspNetCore.Components.DialogReference	36.3%	37.5%
Microsoft.FluentUI.AspNetCore.Components.DialogResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.DialogService	4.1%	2.6%
Microsoft.FluentUI.AspNetCore.Components.Emoji	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiCompress	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.EmojiInfo	0%
Microsoft.FluentUI.AspNetCore.Components.Extensions.AdditionalAttributesExt ensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.BooleanExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.DateTimeExtensions	81.2%	85%
Microsoft.FluentUI.AspNetCore.Components.Extensions.EnumExtensions	70.5%	59%
Microsoft.FluentUI.AspNetCore.Components.Extensions.FluentInputExtensions	25.9%	16.6%
Microsoft.FluentUI.AspNetCore.Components.Extensions.UrlFormatterExtensions	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentAccessibilityStatus	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordion	59.2%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem	78.5%	35.7%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchor	90%	67.8%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchoredRegion	87.7%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBar	64.6%	42.1%
Microsoft.FluentUI.AspNetCore.Components.FluentAppBarItem	85.2%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentAutocomplete`1	85.7%	71.8%
Microsoft.FluentUI.AspNetCore.Components.FluentBadge	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBodyContent	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumb	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBreadcrumbItem	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentButton	84.3%	64.5%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendar	83.4%	78.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarBase	93.7%	81.2%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarDay	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarMonth	92.3%	64.2%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarYear	84.6%	58.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCard	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCheckbox	91.1%	87%
Microsoft.FluentUI.AspNetCore.Components.FluentCollapsibleRegion	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCombobox`1	69%	57.6%
Microsoft.FluentUI.AspNetCore.Components.FluentComponentBase	90.9%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentCounterBadge	92.3%	84.8%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1	57.3%	48.6%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridCell`1	80%	73.9%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridRow`1	56.2%	37.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDatePicker	81.8%	51.9%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignSystemProvider	100%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentDesignTheme	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDialog	57.3%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogBody	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogFooter	66.6%	44.1%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogHeader	85.1%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogProvider	56.4%	53.4%
Microsoft.FluentUI.AspNetCore.Components.FluentDivider	86.9%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDragContainer`1	71.4%
Microsoft.FluentUI.AspNetCore.Components.FluentDragEventArgs`1	0%
Microsoft.FluentUI.AspNetCore.Components.FluentDropZone`1	22.2%	4.3%
Microsoft.FluentUI.AspNetCore.Components.FluentEditForm	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentEmoji`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentFlipper	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFooter	100%
Microsoft.FluentUI.AspNetCore.Components.FluentGrid	72.2%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentGridItem	87.5%	82.5%
Microsoft.FluentUI.AspNetCore.Components.FluentHeader	100%
Microsoft.FluentUI.AspNetCore.Components.FluentHighlighter	80%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentHorizontalScroll	60.6%	20%
Microsoft.FluentUI.AspNetCore.Components.FluentIcon`1	88.3%	81.2%
Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1	69%	61.2%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFile	90%	79.6%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileBuffer	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileEventArgs	92.3%
Microsoft.FluentUI.AspNetCore.Components.FluentInputLabel	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCode	88.6%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeEventArgs	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeProvider	40%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentLabel	98%	88.8%
Microsoft.FluentUI.AspNetCore.Components.FluentLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentListbox`1	94.4%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentMain	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMainLayout	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMenu	60.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuButton	73.1%	25%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuItem	74%	41.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuProvider	95.2%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBar	50.4%	24.1%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBarProvider	70.4%	59%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitter	81.7%	66.6%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterPane	97.1%	91%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterResizeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentNavBase	55.1%	16.6%
Microsoft.FluentUI.AspNetCore.Components.FluentNavGroup	62.3%	35.4%
Microsoft.FluentUI.AspNetCore.Components.FluentNavLink	55.2%	40.6%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenu	61.1%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuGroup	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuItemBase	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuLink	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNavMenuTree	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentNumberField`1	63.8%	55.1%
Microsoft.FluentUI.AspNetCore.Components.FluentOption`1	80%	61.5%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflow	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentOverlay	74%	62%
Microsoft.FluentUI.AspNetCore.Components.FluentPageScript	100%
Microsoft.FluentUI.AspNetCore.Components.FluentPaginator	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentPersona	100%	78.1%
Microsoft.FluentUI.AspNetCore.Components.FluentPopover	78.4%	65.9%
Microsoft.FluentUI.AspNetCore.Components.FluentPresenceBadge	60.9%	29.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProfileMenu	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProgress	81.2%	68.1%
Microsoft.FluentUI.AspNetCore.Components.FluentProgressRing	97.6%	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentPullToRefresh	94%	89.2%
Microsoft.FluentUI.AspNetCore.Components.FluentRadio`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioContext	70%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioGroup`1	77.7%	16.6%
Microsoft.FluentUI.AspNetCore.Components.FluentRating	76.4%	78.2%
Microsoft.FluentUI.AspNetCore.Components.FluentSearch	88.5%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentSelect`1	96.4%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentSkeleton	40.9%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSlider`1	84.7%	68.4%
Microsoft.FluentUI.AspNetCore.Components.FluentSliderLabel`1	65.8%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableList`1	86.9%	59%
Microsoft.FluentUI.AspNetCore.Components.FluentSortableListEventArgs	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentSpacer	100%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentSplashScreen	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentSplitter	70.7%	40%
Microsoft.FluentUI.AspNetCore.Components.FluentStack	82.9%	33.3%
Microsoft.FluentUI.AspNetCore.Components.FluentSwitch	82.6%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentTab	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTabs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTextArea	85%
Microsoft.FluentUI.AspNetCore.Components.FluentTextField	88.8%	60%
Microsoft.FluentUI.AspNetCore.Components.FluentTimePicker	83.3%	58.3%
Microsoft.FluentUI.AspNetCore.Components.FluentToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToastProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentToolbar	68.9%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltip	68.9%	72.7%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltipProvider	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeItem	89.4%	77.7%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeView	79.7%	65.6%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationMessage`1	0%	0%
Microsoft.FluentUI.AspNetCore.Components.FluentValidationSummary	100%	87.5%
Microsoft.FluentUI.AspNetCore.Components.FluentWizard	96%	86.8%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStep	95.8%	88.3%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentWizardStepChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.GlobalState	31.8%	50%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderRequest`1	54.5%	20.8%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult`1	100%
Microsoft.FluentUI.AspNetCore.Components.GridSort`1	35.1%	25.9%
Microsoft.FluentUI.AspNetCore.Components.HeaderFooterContent`1	100%	50%
Microsoft.FluentUI.AspNetCore.Components.HorizontalScrollEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.Icon	83.7%	91.1%
Microsoft.FluentUI.AspNetCore.Components.IconFromImage	100%
Microsoft.FluentUI.AspNetCore.Components.IconInfo	100%
Microsoft.FluentUI.AspNetCore.Components.IconsExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Identifier	66.6%	62.5%
Microsoft.FluentUI.AspNetCore.Components.IdentifierContext	66.6%	41.6%
Microsoft.FluentUI.AspNetCore.Components.IDialogService	0%
Microsoft.FluentUI.AspNetCore.Components.INavMenuItemsOwner	0%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr ibable`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr iber`1	100%	87.5%
Microsoft.FluentUI.AspNetCore.Components.InputHelpers`1	62.1%	48.6%
Microsoft.FluentUI.AspNetCore.Components.InternalAppBarContext	100%	100%
Microsoft.FluentUI.AspNetCore.Components.InternalDialogContext	80%
Microsoft.FluentUI.AspNetCore.Components.InternalListContext`1	80%	66.6%
Microsoft.FluentUI.AspNetCore.Components.InternalToastContext	0%
Microsoft.FluentUI.AspNetCore.Components.KeyCodeService	60.3%	28.5%
Microsoft.FluentUI.AspNetCore.Components.KeyDown	0%	0%
Microsoft.FluentUI.AspNetCore.Components.LibraryConfiguration	88.8%	50%
Microsoft.FluentUI.AspNetCore.Components.ListComponentBase`1	61.3%	62.5%
Microsoft.FluentUI.AspNetCore.Components.LoadedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.LuminanceChangedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.MenuChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.MenuService	63.8%	0%
Microsoft.FluentUI.AspNetCore.Components.Message	50%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBox	50%	0%
Microsoft.FluentUI.AspNetCore.Components.MessageBoxContent	0%
Microsoft.FluentUI.AspNetCore.Components.MessageOptions	76.9%
Microsoft.FluentUI.AspNetCore.Components.MessageService	33%	26.9%
Microsoft.FluentUI.AspNetCore.Components.NavMenuActionArgs	0%	0%
Microsoft.FluentUI.AspNetCore.Components.OfficeColorUtilities	0%
Microsoft.FluentUI.AspNetCore.Components.Option`1	0%
Microsoft.FluentUI.AspNetCore.Components.OptionsSearchEventArgs`1	100%
Microsoft.FluentUI.AspNetCore.Components.OverflowItem	100%
Microsoft.FluentUI.AspNetCore.Components.PaginationState	59%	43.7%
Microsoft.FluentUI.AspNetCore.Components.ProgressFileDetails	100%
Microsoft.FluentUI.AspNetCore.Components.ProgressToast	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ProgressToastContent	0%
Microsoft.FluentUI.AspNetCore.Components.PropertyColumn`2	92.5%	71.7%
Microsoft.FluentUI.AspNetCore.Components.RenderFragmentDialog	100%
Microsoft.FluentUI.AspNetCore.Components.Resources.TimeAgoResource	76.1%	100%
Microsoft.FluentUI.AspNetCore.Components.SelectAllTemplateArgs	100%
Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1	87.3%	82%
Microsoft.FluentUI.AspNetCore.Components.SelectDatesHoverEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.ServiceCollectionExtensions	59.2%	66.6%
Microsoft.FluentUI.AspNetCore.Components.SortedProperty	0%
Microsoft.FluentUI.AspNetCore.Components.SplashScreenContent	0%	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterCollapsedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.SplitterResizedEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.StandardLuminanceExtensions	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TabChangeEventArgs	0%
Microsoft.FluentUI.AspNetCore.Components.TemplateColumn`1	83.3%	0%
Microsoft.FluentUI.AspNetCore.Components.TimeAgoOptions	92.3%
Microsoft.FluentUI.AspNetCore.Components.ToastInstance	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters	0%
Microsoft.FluentUI.AspNetCore.Components.ToastParameters`1	0%
Microsoft.FluentUI.AspNetCore.Components.ToastResult	0%	0%
Microsoft.FluentUI.AspNetCore.Components.ToastService	0%	0%
Microsoft.FluentUI.AspNetCore.Components.TreeChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItem	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItemExpandedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.UploadedFileDetails	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.CssBuilder	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InlineStyleBuilder	96.4%	87.5%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InternalDebounce.Debounc eAction	52.3%	18.7%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InternalDebounce.Debounc eTask	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InternalDebounce.Dispatc herTimerExtensions	82.9%	68.7%
Microsoft.FluentUI.AspNetCore.Components.Utilities.JSModule	0%	0%
Microsoft.FluentUI.AspNetCore.Components.Utilities.RangeOf`1	96.7%	94.4%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Splitter	82.8%	81.8%
Microsoft.FluentUI.AspNetCore.Components.Utilities.StyleBuilder	100%	91.6%
Microsoft.FluentUI.AspNetCore.Components.ZIndex	100%
System.Text.RegularExpressions.Generated	76.4%	53.1%

src/Core/Components/List/ListComponentBase.razor.cs

Remove some test code

dvoituron · 2025-10-21T12:17:09Z

This ListComponentBase class is used by many other components (including Autocomplete). Can you confirm that this will not impact other components? In version 5, we need to add additional unit tests with all these edge cases (null, empty, etc.).

We should also add a unit test in the current version 4 to verify this right away.

vnbaaij · 2025-10-21T14:51:54Z

This ListComponentBase class is used by many other components (including Autocomplete). Can you confirm that this will not impact other components? In version 5, we need to add additional unit tests with all these edge cases (null, empty, etc.).

This change only touches the GetOptionSelected method and returns true in case the Value is equal to the OptionValue (invoked on the item)

dvoituron · 2025-10-21T18:14:08Z

This change only touches the GetOptionSelected method and returns true in case the Value is equal to the OptionValue (invoked on the item)

That's not the only change. You also have a test on IsNullOrEmpty(Value). This could impact other components or cases.

How can we be sure there won't be any regressions?

vnbaaij · 2025-10-21T18:33:12Z

Value was not being considered in this method before this change. I don't see how that could lead to a regression.

vnbaaij · 2025-10-22T06:59:50Z

@microsoft-github-policy-service rerun

vnbaaij · 2025-10-22T07:26:29Z

@microsoft-github-policy-service agree

Fix #4250

3ca00a8

vnbaaij added this to the v4.13.1 milestone Oct 21, 2025

vnbaaij requested a review from dvoituron as a code owner October 21, 2025 08:42

vnbaaij requested a review from Tyme-Bleyaert October 21, 2025 08:42

vnbaaij enabled auto-merge (squash) October 21, 2025 08:47

Tyme-Bleyaert reviewed Oct 21, 2025

View reviewed changes

src/Core/Components/List/ListComponentBase.razor.cs Outdated Show resolved Hide resolved

Refactor condition to check Value only

b97a6e4

Remove some test code

Tyme-Bleyaert approved these changes Oct 21, 2025

View reviewed changes

Merge branch 'dev' into users/vnbaaij/fix-issue-#4250

763d72c

dvoituron approved these changes Oct 21, 2025

View reviewed changes

vnbaaij disabled auto-merge October 22, 2025 11:37

vnbaaij merged commit db185f1 into dev Oct 22, 2025
3 checks passed

vnbaaij deleted the users/vnbaaij/fix-issue-#4250 branch October 22, 2025 11:38

This was referenced Nov 9, 2025

Bump the nuget-dependencies group with 4 updates macel94/blazorazdocustomextsample#5

Open

Bump Microsoft.FluentUI.AspNetCore.Components from 4.13.0 to 4.13.1 AlexHedley/poker-recording#221

Merged

dependabot bot mentioned this pull request Nov 10, 2025

Bump Microsoft.FluentUI.AspNetCore.Components.Emoji from 4.13.0 to 4.13.1 AlexHedley/poker-recording#222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Combobox] Fix presetting option #4255

[Combobox] Fix presetting option #4255

Uh oh!

vnbaaij commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

dvoituron commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 21, 2025

Uh oh!

dvoituron commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 22, 2025

Uh oh!

vnbaaij commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Combobox] Fix presetting option #4255

[Combobox] Fix presetting option #4255

Uh oh!

Conversation

vnbaaij commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary - Unit Tests Code Coverage

Coverage

Uh oh!

Uh oh!

dvoituron commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 21, 2025

Uh oh!

dvoituron commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 21, 2025

Uh oh!

vnbaaij commented Oct 22, 2025

Uh oh!

vnbaaij commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading