[dev-v5] Pull in v4 PRs (part 2) #4218

vnbaaij · 2025-10-06T21:22:34Z

Part 2 of syncing V4 PR's from the last couple of months into the dev-v5 branch

This part implements

[DataGrid] Fix invalid optimization when using Virtualize icw ItemsProvider #4172
[DataGrid] Asynchronous IQueryable based loading and error handling UI feedback #4177
[DataGrid] Optimize style for rendering cell #4178
Remove NoTabbing parameter from DataGrid as it had no implementation (also not on v4!)
Add CustomIcon, IconsExtensions and unit tests

As of 6-10-2025 we are in sync with v4 PRs again!

- Exclude ErrorContent from code coverage - Add (partial) ErrorContentTest, add IsFixed test, update tests

Related Work Items: #41

github-actions · 2025-10-06T21:24:56Z

✅ All tests passed successfully

Details on your Workflow / Core Tests page.

github-actions · 2025-10-06T21:25:02Z

Summary - Unit Tests Code Coverage

Summary


Generated on:	10/08/2025 - 15:49:23
Coverage date:	10/08/2025 - 15:49:11
Parser:	Cobertura
Assemblies:	1
Classes:	188
Files:	257
Line coverage:	98.7% (6207 of 6283)
Covered lines:	6207
Uncovered lines:	76
Coverable lines:	6283
Total lines:	24775
Branch coverage:	92.3% (3573 of 3871)
Covered branches:	3573
Total branches:	3871
Method coverage:	Feature is only available for sponsors
Tag:	4410_18350265286

Coverage

Microsoft.FluentUI.AspNetCore.Components - 98.7%

Name	Line	Branch
Microsoft.FluentUI.AspNetCore.Components	98.7%	92.3%
Microsoft.FluentUI.AspNetCore.Components.AccordionItemEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.AdditionalAttributesExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.CachedServices	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Calendar.CalendarExtended	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Calendar.CalendarTitles`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Calendar.CalendarTValue	100%	100%
Microsoft.FluentUI.AspNetCore.Components.ColumnBase`1	97.2%	90.2%
Microsoft.FluentUI.AspNetCore.Components.ColumnKeyGridSort`1	94.4%	75%
Microsoft.FluentUI.AspNetCore.Components.ColumnOptionsUISettings	100%
Microsoft.FluentUI.AspNetCore.Components.ColumnResizeOptions`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.ColumnResizeUISettings	100%
Microsoft.FluentUI.AspNetCore.Components.ColumnSortUISettings	100%
Microsoft.FluentUI.AspNetCore.Components.CustomIcon	100%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.Defer	100%
Microsoft.FluentUI.AspNetCore.Components.DataGrid.Infrastructure.InternalGr idContext`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DateTimeProvider	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DateTimeProviderContext	95.6%	92.8%
Microsoft.FluentUI.AspNetCore.Components.DefaultStyles	100%
Microsoft.FluentUI.AspNetCore.Components.Dialog.MessageBox.FluentMessageBox	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogEventArgs	100%	92.8%
Microsoft.FluentUI.AspNetCore.Components.DialogInstance	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogOptions	100%
Microsoft.FluentUI.AspNetCore.Components.DialogOptionsFooter	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogOptionsFooterAction	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogOptionsHeader	100%
Microsoft.FluentUI.AspNetCore.Components.DialogResult	100%	100%
Microsoft.FluentUI.AspNetCore.Components.DialogResult`1	100%
Microsoft.FluentUI.AspNetCore.Components.DialogService	100%	82.3%
Microsoft.FluentUI.AspNetCore.Components.DialogToggleEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.DropdownEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.DateTimeExtensions	100%	92%
Microsoft.FluentUI.AspNetCore.Components.Extensions.DisplayAttributeExtensi ons	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.EnumExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.FieldSizeExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Extensions.FluentInputExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FileSizeConverter	100%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordion	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem	100%	95%
Microsoft.FluentUI.AspNetCore.Components.FluentAnchorButton	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentAvatar	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentBadge	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentButton	98.4%	90.6%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendar`1	98.1%	88.3%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarBase`1	100%	94.4%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarDay`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarMonth`1	100%	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentCalendarYear`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCard	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCheckbox	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCombobox`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentComponentBase	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCompoundButton	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentCounterBadge	100%	96.1%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1	90.6%	87.5%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridCell`1	100%	88%
Microsoft.FluentUI.AspNetCore.Components.FluentDataGridRow`1	98.5%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDatePicker`1	97.4%	85.2%
Microsoft.FluentUI.AspNetCore.Components.FluentDialog	97.5%	88%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogBody	100%	91.6%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogInstance	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentDialogProvider	100%	71.7%
Microsoft.FluentUI.AspNetCore.Components.FluentDivider	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentErrorBoundary	97.6%	93.7%
Microsoft.FluentUI.AspNetCore.Components.FluentField	100%	96.5%
Microsoft.FluentUI.AspNetCore.Components.FluentFieldCondition	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFieldConditionItem	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFieldConditionOptions	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFieldExtensions	100%
Microsoft.FluentUI.AspNetCore.Components.FluentFieldParameterSelector	100%	98.7%
Microsoft.FluentUI.AspNetCore.Components.FluentGrid	100%	90%
Microsoft.FluentUI.AspNetCore.Components.FluentGridItem	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentHighlighter	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentIcon`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentImage	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputBase`1	93.8%	50%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFile	100%	93.3%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileBuffer	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileErrorEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputFileEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentInputImmediateBase`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentJSModule	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCode	100%	92.8%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeEventArgs	100%	75%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyCodeProvider	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentKeyPressEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentLabel	100%
Microsoft.FluentUI.AspNetCore.Components.FluentLayout	100%	88.8%
Microsoft.FluentUI.AspNetCore.Components.FluentLayoutHamburger	100%	96.4%
Microsoft.FluentUI.AspNetCore.Components.FluentLayoutItem	100%	91%
Microsoft.FluentUI.AspNetCore.Components.FluentLink	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentListBase`1	97.3%	92.1%
Microsoft.FluentUI.AspNetCore.Components.FluentLocalizerExtensions	100%
Microsoft.FluentUI.AspNetCore.Components.FluentLocalizerInternal	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMenu	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuButton	100%	71.4%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuItem	100%	90.4%
Microsoft.FluentUI.AspNetCore.Components.FluentMenuList	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMessageBar	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitter	100%	91.8%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterPane	100%	89.4%
Microsoft.FluentUI.AspNetCore.Components.FluentMultiSplitterResizeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.FluentOption	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentPaginator	100%	94.4%
Microsoft.FluentUI.AspNetCore.Components.FluentPopover	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProgress	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProgressBar	100%	95.4%
Microsoft.FluentUI.AspNetCore.Components.FluentProgressRing	100%
Microsoft.FluentUI.AspNetCore.Components.FluentProviders	100%
Microsoft.FluentUI.AspNetCore.Components.FluentRadio`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentRadioGroup`1	100%	88.8%
Microsoft.FluentUI.AspNetCore.Components.FluentRatingDisplay	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSelect`1	96.1%	83.3%
Microsoft.FluentUI.AspNetCore.Components.FluentServiceBase`1	100%
Microsoft.FluentUI.AspNetCore.Components.FluentServiceProviderException`1	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSkeleton	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSlider`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSpacer	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSpinner	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSplitButton	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentStack	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentStatus	100%
Microsoft.FluentUI.AspNetCore.Components.FluentSwitch	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTab	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTabs	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentText	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTextArea	100%	70%
Microsoft.FluentUI.AspNetCore.Components.FluentTextInput	100%	81.2%
Microsoft.FluentUI.AspNetCore.Components.FluentTimePicker`1	100%	81.1%
Microsoft.FluentUI.AspNetCore.Components.FluentToggleButton	100%	91.6%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltip	100%	95%
Microsoft.FluentUI.AspNetCore.Components.FluentTooltipProvider	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeItem	100%	95.3%
Microsoft.FluentUI.AspNetCore.Components.FluentTreeView	100%	100%
Microsoft.FluentUI.AspNetCore.Components.FreeOptionOutput	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderRequest`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult	100%
Microsoft.FluentUI.AspNetCore.Components.GridItemsProviderResult`1	100%
Microsoft.FluentUI.AspNetCore.Components.GridSort`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.HighlighterSplitter	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Icon	100%	95%
Microsoft.FluentUI.AspNetCore.Components.IconFromImage	100%
Microsoft.FluentUI.AspNetCore.Components.IconInfo	100%
Microsoft.FluentUI.AspNetCore.Components.IconsExtensions	76.9%	16.6%
Microsoft.FluentUI.AspNetCore.Components.IFluentComponentChangeAfterKeyPres s	100%	100%
Microsoft.FluentUI.AspNetCore.Components.IFluentLocalizer	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr ibable`1	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Infrastructure.EventCallbackSubscr iber`1	100%	87.5%
Microsoft.FluentUI.AspNetCore.Components.InputFileInstance	100%	100%
Microsoft.FluentUI.AspNetCore.Components.InputFileOptions	100%
Microsoft.FluentUI.AspNetCore.Components.InternalListContext`1	100%
Microsoft.FluentUI.AspNetCore.Components.KeyCodeService	100%	85.7%
Microsoft.FluentUI.AspNetCore.Components.KeyPress	100%
Microsoft.FluentUI.AspNetCore.Components.LayoutHamburgerEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.LibraryTooltipOptions	100%
Microsoft.FluentUI.AspNetCore.Components.Localization.LanguageResource	100%	100%
Microsoft.FluentUI.AspNetCore.Components.MenuItemEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.MessageBoxOptions	100%
Microsoft.FluentUI.AspNetCore.Components.Migration.AppearanceExtensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Migration.FluentInputAppearanceExt ensions	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Migration.TooltipPositionExtension	100%	100%
Microsoft.FluentUI.AspNetCore.Components.PaginationState	100%	81.2%
Microsoft.FluentUI.AspNetCore.Components.ProgressFileDetails	100%
Microsoft.FluentUI.AspNetCore.Components.PropertyColumn`2	100%	81.8%
Microsoft.FluentUI.AspNetCore.Components.RadioEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.RangeOfDates	100%	100%
Microsoft.FluentUI.AspNetCore.Components.SelectAllTemplateArgs	100%
Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1	97.2%	94%
Microsoft.FluentUI.AspNetCore.Components.ServiceProviderExtensions	100%
Microsoft.FluentUI.AspNetCore.Components.SortedProperty	100%
Microsoft.FluentUI.AspNetCore.Components.SpacingExtensions	100%	97.2%
Microsoft.FluentUI.AspNetCore.Components.TabChangeEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TemplateColumn`1	100%	25%
Microsoft.FluentUI.AspNetCore.Components.TooltipEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TotalItemCountChangedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TreeItemChangedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItem	100%	100%
Microsoft.FluentUI.AspNetCore.Components.TreeViewItemExpandedEventArgs	100%
Microsoft.FluentUI.AspNetCore.Components.UploadedFileDetails	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.AddTag	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.CssBuilder	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Debounce	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.Identifier	100%	100%
Microsoft.FluentUI.AspNetCore.Components.Utilities.IdentifierContext	100%	75%
Microsoft.FluentUI.AspNetCore.Components.Utilities.InlineStyleBuilder	100%	92.8%
Microsoft.FluentUI.AspNetCore.Components.Utilities.RangeOf`1	96.7%	97.2%
Microsoft.FluentUI.AspNetCore.Components.Utilities.StyleBuilder	100%	100%
Microsoft.FluentUI.AspNetCore.Components.ZIndex	100%

src/Core/Components/DataGrid/FluentDataGrid.razor

src/Core/Components/DataGrid/FluentDataGrid.razor.cs

dvoituron

Can you update the PR title before to merge?
"Sync with v4 (part 2)" is not very clear for me :-)

vnbaaij added 11 commits October 2, 2025 22:52

Implement #4036

f76ba2e

Implement #4070

df08371

Implement #4112

734bd5e

Implement #4116

f928a1c

Add extra test. Brings back code coverage to 100% for Row and Cell

5e76a6c

Implement #4172

be46fe0

Implement #4177

89d2472

Merge branch 'dev-v5' into users/vnbaaij.dev-v5/sync-with-v4-part2

43d5170

- Remove NoTabbing parameter (not being used)

0dc3ede

- Exclude ErrorContent from code coverage - Add (partial) ErrorContentTest, add IsFixed test, update tests

Implement #4178

0f01e2a

Related Work Items: #41

Add CustomIcon and IconsExtensions + tests

8d4a54e

vnbaaij requested a review from dvoituron as a code owner October 6, 2025 21:22

dvoituron reviewed Oct 8, 2025

View reviewed changes

src/Core/Components/DataGrid/FluentDataGrid.razor Show resolved Hide resolved

dvoituron reviewed Oct 8, 2025

View reviewed changes

src/Core/Components/DataGrid/FluentDataGrid.razor.cs Show resolved Hide resolved

dvoituron approved these changes Oct 8, 2025

View reviewed changes

Merge branch 'dev-v5' into users/vnbaaij/dev-v5/sync-with-v4-part2

6f4285b

vnbaaij changed the title ~~[dev-v5] Sync with v4 (part 2)~~ [dev-v5] Pull in v4 PRs (part 2) Oct 8, 2025

vnbaaij merged commit a516910 into dev-v5 Oct 8, 2025
4 checks passed

vnbaaij deleted the users/vnbaaij/dev-v5/sync-with-v4-part2 branch October 8, 2025 15:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dev-v5] Pull in v4 PRs (part 2) #4218

[dev-v5] Pull in v4 PRs (part 2) #4218

Uh oh!

vnbaaij commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dvoituron left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[dev-v5] Pull in v4 PRs (part 2) #4218

[dev-v5] Pull in v4 PRs (part 2) #4218

Uh oh!

Conversation

vnbaaij commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary - Unit Tests Code Coverage

Coverage

Uh oh!

Uh oh!

Uh oh!

dvoituron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading