Skip to content

Conversation

@hml-coder
Copy link
Contributor

@hml-coder hml-coder commented Jan 16, 2025

Pull Request

📖 Description

Set EnableClickToClose to true to enable dismissing the FluentCombobox dropdown list by clicking the dropdown button.

🎫 Issues

Addresses an issue with the web components fluent-combobox where the dropdown list cannot be closed by clicking the arrow indicator.

👩‍💻 Reviewer Notes

📑 Test Plan

Tried to create a test but the shadowRoot was empty and I'm not sure how to pre-load the required JavaScript handlers into the tests.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@hml-coder hml-coder changed the title Add EnableClickToClose to FluentCombobox for dropdown toggle control. [FluentCombobox] Add EnableClickToClose Jan 16, 2025
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dvoituron dvoituron merged commit 94305a5 into microsoft:dev Jan 16, 2025
4 checks passed
@hml-coder hml-coder deleted the issue/fix-blocked-issue-1693 branch January 16, 2025 12:58
@rpodevns
Copy link
Contributor

rpodevns commented Feb 7, 2025

Same behavior in web compnents v3. Clicking the indicator does not close the Combobox.

https://web-components.fluentui.dev/?path=/docs/components-combobox--docs

@vnbaaij
Copy link
Collaborator

vnbaaij commented Feb 7, 2025

I've flagged this in the fluentui v3 repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants