Skip to content

[InputFile] [Docs] Add null check on initialization #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Dec 18, 2024
Merged

[InputFile] [Docs] Add null check on initialization #3062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e105a0
Fix CodeSnippet
MarvinKlein1508 Dec 18, 2024
e6813d0
Fix 3061
MarvinKlein1508 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions examples/Demo/Shared/Components/CodeSnippet.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export function addCopyButton() {
}

export function highlightElement(id) {
if (hljs) {
hljs.highlightElement(id);
try {
hljs?.highlightElement(id);
} catch (e) {
// highlightJS may fail when the user navigates away from the page quickly. Which when not catched will result in a crash.
}
}
20 changes: 10 additions & 10 deletions src/Core/Components/InputFile/FluentInputFile.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,20 @@ export function initializeFileDropZone(containerElement, inputFile) {
//}

// Register all events
containerElement.addEventListener("dragenter", onDragHover);
containerElement.addEventListener("dragover", onDragHover);
containerElement.addEventListener("dragleave", onDragLeave);
containerElement.addEventListener("drop", onDrop);
//containerElement.addEventListener('paste', onPaste);
containerElement?.addEventListener("dragenter", onDragHover);
containerElement?.addEventListener("dragover", onDragHover);
containerElement?.addEventListener("dragleave", onDragLeave);
containerElement?.addEventListener("drop", onDrop);
//containerElement?.addEventListener('paste', onPaste);

// The returned object allows to unregister the events when the Blazor component is destroyed
return {
dispose: () => {
containerElement.removeEventListener('dragenter', onDragHover);
containerElement.removeEventListener('dragover', onDragHover);
containerElement.removeEventListener('dragleave', onDragLeave);
containerElement.removeEventListener("drop", onDrop);
//containerElement.removeEventListener('paste', onPaste);
containerElement?.removeEventListener('dragenter', onDragHover);
containerElement?.removeEventListener('dragover', onDragHover);
containerElement?.removeEventListener('dragleave', onDragLeave);
containerElement?.removeEventListener("drop", onDrop);
//containerElement?.removeEventListener('paste', onPaste);
}
}
}
Loading