-
Notifications
You must be signed in to change notification settings - Fork 461
[Icons Emijis] Split to multiple DLLs in a single NuGet package #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 59.9%
|
Collaborator
Author
|
Duplicated #2990... Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Icons Emijis] Split to multiple DLLs in a single NuGet package
We need to split the Icons library into several DLLs. Currently, all icons are in a single file and compiled at once. Unfortunately, .NET and C# have a maximum number of strings available in a single C# project. We therefore decided to split .cs files into several DLLs.
To do this, subclasses must be transformed into namespace (with the same name).
It is also necessary to centralize the
Iconsclass (renamed toIconsExtensions) in the Components library used by Icons and Emojis.Build process
To build the NuGet package, we need to build each DLLs using commands like
Next a package could be creating using a
csprojsimilar to this one.