Skip to content

Conversation

@svrooij
Copy link
Contributor

@svrooij svrooij commented Nov 25, 2024

Fixed #2839

Pull Request

📖 Description

Paging or sorting for a data grid will now save the state in the url, if the developer opt-ed in for this on that grid. It also supports a prefix, in case you would have multiple grids on a single page.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component 404

⏭ Next Steps

@svrooij svrooij force-pushed the feature/gird-state-to-url branch from aa4607e to 75cf6ff Compare November 25, 2024 21:35
@vnbaaij vnbaaij changed the title Grid paging state saved in url [Grid] Save paging state in URL Nov 25, 2024
@svrooij
Copy link
Contributor Author

svrooij commented Nov 26, 2024

@vnbaaij and @dvoituron the tests work on my machine, I see the build is also failing on the dev branch. Is that something that needs investigating?

For one of my projects I use the GitHub Actions test logger to produce these nice looking stats in the action. It will also show exactly which test failed (if any). Is that something you might also want in your pipeline?

@vnbaaij vnbaaij changed the title [Grid] Save paging state in URL [DataGrid] Save paging state in URL Nov 26, 2024
@svrooij svrooij force-pushed the feature/gird-state-to-url branch from 78ba9f3 to ce1deff Compare November 26, 2024 11:08
@dvoituron
Copy link
Collaborator

@vnbaaij and @dvoituron the tests work on my machine, I see the build is also failing on the dev branch. Is that something that needs investigating?

We have a similar process in our Pipeline:
{0C01C70E-8C4D-4805-9556-5637A2C960C6}

But the problem comes with user rights (for automatic publication in the RP comment stream): Repo owners see this report but not you :-)

But in this case, it's more a .NET9 issue. @vnbaaij did you changed something?

@svrooij
Copy link
Contributor Author

svrooij commented Nov 26, 2024

One log line said it could not download dotnet 9.0 ga, so I think it has to do with the official release of dotnet9

@vnbaaij
Copy link
Collaborator

vnbaaij commented Nov 26, 2024

One log line said it could not download dotnet 9.0 ga, so I think it has to do with the official release of dotnet9

There was a reference still to .net9 preview in a pipeline. This has been corrected

But in this case, it's more a .NET9 issue. @vnbaaij did you changed something?

Yes, but this test has already been fixed

@vnbaaij vnbaaij added this to the v4.11 milestone Nov 26, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) November 26, 2024 13:01
@svrooij
Copy link
Contributor Author

svrooij commented Nov 26, 2024

@vnbaaij someone has to press the button to run the tests for the final time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add url support to DataGrid

3 participants