-
Notifications
You must be signed in to change notification settings - Fork 461
[DataGrid] Save paging state in URL #2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aa4607e to
75cf6ff
Compare
|
@vnbaaij and @dvoituron the tests work on my machine, I see the build is also failing on the dev branch. Is that something that needs investigating? For one of my projects I use the GitHub Actions test logger to produce these nice looking stats in the action. It will also show exactly which test failed (if any). Is that something you might also want in your pipeline? |
78ba9f3 to
ce1deff
Compare
We have a similar process in our Pipeline: But the problem comes with user rights (for automatic publication in the RP comment stream): Repo owners see this report but not you :-) But in this case, it's more a .NET9 issue. @vnbaaij did you changed something? |
|
One log line said it could not download dotnet 9.0 ga, so I think it has to do with the official release of dotnet9 |
There was a reference still to .net9 preview in a pipeline. This has been corrected
Yes, but this test has already been fixed |
|
@vnbaaij someone has to press the button to run the tests for the final time. |

Fixed #2839
Pull Request
📖 Description
Paging or sorting for a data grid will now save the state in the url, if the developer opt-ed in for this on that grid. It also supports a prefix, in case you would have multiple grids on a single page.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
404⏭ Next Steps