Skip to content

Conversation

@oneolddev
Copy link
Contributor

Pull Request

πŸ“– Description

Fixes issue where member description missing from components inheriting from ListComponentBase<>.

🎫 Issues

image

πŸ‘©β€πŸ’» Reviewer Notes

image

I added a private function that recursively searches for a possible description in one of the base classes.

πŸ“‘ Test Plan

Visually checked.

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@oneolddev
Copy link
Contributor Author

I'm not sure why Build and Test Core Lib / Build and Test Core Lib (pull_request) is failing. It appears it has something to do with

warning : [coverlet] badimageformatexception during metadatareaderprovider.fromportablepdbstream in instrumentationhelper.portablepdbhaslocalsource, unable to check if module has got local source.

Help!

@oneolddev
Copy link
Contributor Author

@vnbaaij, Your re-run worked. πŸ™‚ What changed?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 30, 2024

Nothing! Just gets stuck that way sometimes. Have not had time (interest) to dig into it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants