Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

Pull Request

📖 Description

This PR adds a null check for the FluentTimePicker which converts empty strings to DateTime?.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

I've added a new UNIT Test FluentTimePicker_EmptyStringToNull to verfiy the results.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@MarvinKlein1508
Copy link
Collaborator Author

@dvoituron should be good now :)

@vnbaaij vnbaaij changed the title [FluentTimePicker] Add null check for empty string [TimePicker] Add null check for empty string Jun 24, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) June 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants