v1 Date-time picker dailog orientation #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonurajz
approved these changes
Aug 23, 2024
FluentUI.Demo/src/main/java/com/microsoft/fluentuidemo/demos/DateTimePickerActivity.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The behavior of date-time picker dialog was not right on screen orientation change. In demo-app, it was closing the dialog.
Root cause
Dialog doesn't have a lifecycle like a fragment which can handle these changes on it's own.
Fix
Recreation of date-time picker dialog on orientation change
and also making sure date-time is saved and maintained across the changes.
Validations
(how the change was tested, including both manual and automated tests)
Screenshots
Before
time.date.picker.dialog.before.webm
After
dateTimeDialog After.webm
Pull request checklist
This PR has considered: