Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Basic Card: Modifier order revert #649

Merged
merged 3 commits into from
May 2, 2024

Conversation

Anubhvv
Copy link
Collaborator

@Anubhvv Anubhvv commented May 2, 2024

Problem

User passed modifier order was creating problems.

Root cause

Fix

Applying user passed modifier before internal modifiers.

Validations

(how the change was tested, including both manual and automated tests)

Screenshots

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@Anubhvv Anubhvv requested a review from a team as a code owner May 2, 2024 08:56
@Anubhvv Anubhvv changed the title V2 Basic Card: Now supports two modifier params differing in their order of application V2 Basic Card: Modifier order revert May 2, 2024
@Anubhvv Anubhvv merged commit 5da577c into microsoft:master May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants