Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Basic Card API changes #645

Merged
merged 3 commits into from
May 1, 2024
Merged

V2 Basic Card API changes #645

merged 3 commits into from
May 1, 2024

Conversation

Anubhvv
Copy link
Collaborator

@Anubhvv Anubhvv commented Apr 22, 2024

Problem

  1. User is not able to create Outlined Basic Card, default type is Elevated Card.
  2. modifiers passed as param may be overriden existing modifiers due to their order

Root cause

  1. Deafult type ofCard has been defined inside composable, and i.e "Elevated"
  2. Order of modifiers applied

Fix

  1. Let user pass BasicCardInfo
  2. Change order of modifiers

Validations

(how the change was tested, including both manual and automated tests)

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@Anubhvv Anubhvv requested a review from a team as a code owner April 22, 2024 09:34
@Anubhvv Anubhvv merged commit 5744fca into microsoft:master May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants