Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Add support for managed identities #9

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add support for managed identities #9

merged 2 commits into from
Aug 11, 2020

Conversation

elsesiy
Copy link
Contributor

@elsesiy elsesiy commented Mar 30, 2020

Fix #5

@msftclas
Copy link

msftclas commented Mar 30, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@elsesiy
Copy link
Contributor Author

elsesiy commented Mar 30, 2020

@microsoftopensource Please review

@elsesiy
Copy link
Contributor Author

elsesiy commented Apr 6, 2020

@logachev Can you please take a look here?

@elsesiy
Copy link
Contributor Author

elsesiy commented Apr 11, 2020

@microsoftopensource @logachev Any feedback?

@elsesiy
Copy link
Contributor Author

elsesiy commented Apr 24, 2020

@microsoftopensource @logachev It would be great to get this merged soon, thanks.

@logachev
Copy link
Contributor

@elsesiy I'm sorry for the delay, was busy with another project.
I will take a look tomorrow! Thanks for doing this!

@elsesiy
Copy link
Contributor Author

elsesiy commented Apr 24, 2020

@logachev Great, thanks! Let me know if it needs work and I get it done right away

@elsesiy elsesiy mentioned this pull request Apr 27, 2020
Closed
logachev
logachev reviewed Apr 29, 2020
View reviewed changes
@elsesiy elsesiy marked this pull request as draft April 30, 2020 13:53
@logachev
Copy link
Contributor

logachev commented May 7, 2020

@elsesiy is there a reason you put it to the draft?

@elsesiy
Copy link
Contributor Author

elsesiy commented May 7, 2020

@logachev Yes, please look at the referenced issue. This code is working as expected but there seems to be an issue in the azure-storage-ruby SDK where a token refresh doesn’t lead to a successful connection after the initial token expires

@elsesiy elsesiy marked this pull request as ready for review May 11, 2020 01:23
@elsesiy
Copy link
Contributor Author

elsesiy commented May 11, 2020

@logachev Please have another look at the PR

@elsesiy elsesiy requested a review from logachev August 5, 2020 06:05
@elsesiy
Copy link
Contributor Author

elsesiy commented Aug 5, 2020

@logachev This PR is ready for review, can you have another look please?

wesyao
wesyao reviewed Aug 11, 2020
View reviewed changes
wesyao
wesyao reviewed Aug 11, 2020
View reviewed changes
@elsesiy
Copy link
Contributor Author

elsesiy commented Aug 11, 2020

@wesyao I addressed your comments in the latest commit 67ff869, please let me know if you have any further remarks.

@elsesiy elsesiy requested a review from wesyao August 11, 2020 05:43
@wesyao
Copy link

wesyao commented Aug 11, 2020

lgtm

@logachev logachev merged commit 6c76ea7 into microsoft:master Aug 11, 2020
@elsesiy elsesiy deleted the feat/managed-identity branch August 12, 2020 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@logachev logachev logachev approved these changes

@wesyao wesyao wesyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can this be modified to support accessing blobs with MSI?
4 participants
@elsesiy @msftclas @logachev @wesyao