This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Use GET on the container to check if the storage container exists #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logachev
suggested changes
Aug 11, 2020
| @@ -115,10 +115,23 @@ def write(chunk) | |||
| tmp.unlink | |||
| end | |||
| end | |||
|
|
|||
| def container_exists?(container) | |||
There was a problem hiding this comment.
Can you please add a test for this function?
There was a problem hiding this comment.
I added tests for this function.
The list_containers op will return a max of 5000 containers. This causes the container check to fail when there are > 5000 containers in the storage account. Using a GET on the container avoids this limit.
avoltz
force-pushed
the
container_exist_check
branch
from
35b34e0 to
b1b5eb8
Compare
|
|
logachev
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list_containers op will return a max of 5000 containers. This
causes the container check to fail when there are > 5000 containers
in the storage account. Using a GET on the container avoids this limit.
This fixes #15