Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

Support of provided SAS token instead of keys #12

Merged
merged 8 commits into from
May 7, 2020

Conversation

maxkochubey
Copy link
Contributor

  • One more optional azure_storage_sas_token config parameter was added.

@maxkochubey
Copy link
Contributor Author

@microsoftopensource, please take a look.

Copy link
Contributor

@logachev logachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you just add an extra check?

@elsesiy
Copy link
Contributor

elsesiy commented May 7, 2020

Also I tried using the code with the small change I proposed and it's not working, see
Azure/azure-storage-ruby#163

@logachev logachev merged commit 9c22e41 into microsoft:master May 7, 2020
@logachev
Copy link
Contributor

logachev commented May 7, 2020

@elsesiy please let me know if there is an issue. I'll merge outstanding PRs and will run tests before releasing new version.

@elsesiy
Copy link
Contributor

elsesiy commented May 7, 2020

@logachev I have the code deployed and it does not work so please conduct your testing and report back with instructions on how to use the SAS token generated from the Azure Portal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants