-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds StorageInitialized health check #4674
Merged
brendankowitz
merged 2 commits into
main
from
personal/bkowitz/storageinitialzied-healthcheck
Oct 11, 2024
Merged
Adds StorageInitialized health check #4674
brendankowitz
merged 2 commits into
main
from
personal/bkowitz/storageinitialzied-healthcheck
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
added
Enhancement
Enhancement on existing functionality.
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
labels
Oct 11, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
brendankowitz
added
the
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
label
Oct 11, 2024
brendankowitz
force-pushed
the
personal/bkowitz/storageinitialzied-healthcheck
branch
from
October 11, 2024 20:10
17eee76
to
cfda8f1
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
LTA-Thinking
previously approved these changes
Oct 11, 2024
...osoft.Health.Fhir.Shared.Api.UnitTests/Features/Health/StorageInitializedHealthCheckTests.cs
Show resolved
Hide resolved
LTA-Thinking
approved these changes
Oct 11, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
brendankowitz
deleted the
personal/bkowitz/storageinitialzied-healthcheck
branch
October 11, 2024 23:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Enhancement
Enhancement on existing functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new health check for storage initialization and includes related unit tests. Additionally, it updates project files to support these changes.
New Features:
src/Microsoft.Health.Fhir.Api/Features/Health/StorageInitializedHealthCheck.cs
: Added a new health check classStorageInitializedHealthCheck
to monitor the initialization status of storage.Unit Tests:
src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Features/Health/StorageInitializedHealthCheckTests.cs
: Added unit tests for theStorageInitializedHealthCheck
class to verify its behavior under different conditions.Project File Updates:
src/Microsoft.Health.Fhir.Api.UnitTests/Microsoft.Health.Fhir.R4.Api.UnitTests.csproj
: Added a conditional package reference forMicrosoft.Extensions.TimeProvider.Testing
when the target framework is notnet6.0
.src/Microsoft.Health.Fhir.Shared.Api.UnitTests/Microsoft.Health.Fhir.Shared.Api.UnitTests.projitems
: Included the new test fileStorageInitializedHealthCheckTests.cs
and removed an unused folder reference. [1] [2]Dependency Injection:
src/Microsoft.Health.Fhir.Shared.Api/Modules/FhirModule.cs
: RegisteredStorageInitializedHealthCheck
as a singleton service and added it to the health checks. [1] [2]Related issues
Addresses AB#130097
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch