Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix descending sort #4661

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix descending sort #4661

merged 2 commits into from
Oct 7, 2024

Conversation

LTA-Thinking
Copy link
Collaborator

Description

This fixes a bug where if descending sort is used and no resources match the sort field then the second phase of the sort, which gets fields that don't have the sort field, won't run.

Related issues

Addresses Bug 126375: Descending sort will return no results if no data has the search field

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Oct 4, 2024
@LTA-Thinking LTA-Thinking added this to the S151 milestone Oct 4, 2024
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner October 4, 2024 22:10
fhibf
fhibf previously approved these changes Oct 4, 2024
@LTA-Thinking LTA-Thinking merged commit 4680bec into main Oct 7, 2024
47 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/decending-sort-fix branch October 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants