fix: rtl scroll converter test asserting incorrect values #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
chrisdholt,
nicholasrice and
EisenbergEffect
as code owners
radium-v
force-pushed
the
users/jokreitl/fix-rtl-scroll-converter-test
branch
from
6f2448e to
758ddfd
Compare
- Chromium reports 0.5 - Webkit and Firefox both report 0
radium-v
force-pushed
the
users/jokreitl/fix-rtl-scroll-converter-test
branch
from
758ddfd to
5e8ecde
Compare
scomea
approved these changes
Nov 10, 2023
chrisdholt
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Changes the
invertedGetRtlScrollConverter returns correct valuetest to pass when any value < 0 is returned.🎫 Issues
This PR reverts #6857.
👩💻 Reviewer Notes
The behavior seems to be related to this Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1324251
It's something called "zoom for DSF" on MacOS, which leads to inaccurate value reporting:
10.500So while I do still think that screen DPI is partly to blame for Chrome returning
0.5, it seems that settingscrollLeftto1when in rtl mode and receiving anything other than0is a bug.✅ Checklist
General
$ yarn change