Fix: picker show no options #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
change/@microsoft-fast-foundation-4ed56949-7343-439d-9bd1-4f76b36c9d1d.json
Outdated
Show resolved
Hide resolved
awentzel
approved these changes
May 15, 2023
nicholasrice
approved these changes
May 15, 2023
chrisdholt
approved these changes
May 16, 2023
KingOfTac
pushed a commit
that referenced
this pull request
Jun 17, 2023
* show no options * Change files * Update change/@microsoft-fast-foundation-4ed56949-7343-439d-9bd1-4f76b36c9d1d.json --------- Co-authored-by: Aaron Wentzel <16669785+awentzel@users.noreply.github.com> Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* show no options * Change files * Update change/@microsoft-fast-foundation-4ed56949-7343-439d-9bd1-4f76b36c9d1d.json --------- Co-authored-by: Aaron Wentzel <16669785+awentzel@users.noreply.github.com> Co-authored-by: Nicholas Rice <3213292+nicholasrice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Picker "no options" display shows up one keystroke too late because the current detection happens before invalid options based on the last char typed are removed from the dom.
🎫 Issues
ad-ho
✅ Checklist
General
$ yarn changeComponent-specific