fix: picker filter should be case insensitive #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
awentzel
approved these changes
Apr 3, 2023
eljefe223
approved these changes
Apr 3, 2023
KingOfTac
approved these changes
Apr 3, 2023
chrisdholt
approved these changes
Apr 3, 2023
KingOfTac
pushed a commit
that referenced
this pull request
Apr 30, 2023
* picker filter ignores case * Change files * change correction --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
KingOfTac
pushed a commit
that referenced
this pull request
Jun 17, 2023
* picker filter ignores case * Change files * change correction --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* picker filter ignores case * Change files * change correction --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Picker option filtering should be case insensitive. We could consider adding customizability later, but the default should be permissive.
🎫 Issues
ad-hoc
✅ Checklist
General
$ yarn changeComponent-specific