feat: shim DOMTokenList for class and part properties on HTMLElement #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
YusakuNo1
approved these changes
Nov 16, 2022
janechu
approved these changes
Nov 16, 2022
EisenbergEffect
deleted the
users/eisenbergeffect/dom-token-list-shim
branch
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
…6522) * feat: shim DOMTokenList for class and part properties on HTMLElement * test: add for DOMTokenList * Change files * chore: correct change file Co-authored-by: EisenbergEffect <roeisenb@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds
classList,className, andpartproperties to theHTMLElementshim for SSR.🎫 Issues
👩💻 Reviewer Notes
The main part of this PR is the introduction of an implementation of
DOMTokenListwhich is then plugged intoHTMLElementwhere appropriate.📑 Test Plan
Tests for
DOMTokenListwere added. Existing tests continue to pass.✅ Checklist
General
$ yarn change⏭ Next Steps
Explore whether any other shims are needed to enable foundation components to function out of the box.