fix max call stack exceeded when setting token values from change handler #6499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
EisenbergEffect,
chrisdholt and
janechu
as code owners
nicholasrice
force-pushed
the
users/nirice/fix-max-call-stack-exceeded
branch
from
724ccfe to
3ae2393
Compare
EisenbergEffect
approved these changes
Nov 4, 2022
chrisdholt
approved these changes
Nov 7, 2022
|
@nicholasrice I think this one is ready whenever you are. |
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
…dler (#6499) * fixing issue and adding regression tests * Change files Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com> Co-authored-by: Chris Holt <chhol@microsoft.com> Co-authored-by: Rob Eisenberg <EisenbergEffect@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR fixes an bug where setting a token value from a subscriber causes a RangeError, max call stack exceeded.
🎫 Issues
Closes #6464
👩💻 Reviewer Notes
The core of the issue is that setting a token from a subscriber would force DesignToken to go through the notification code-path again. Because the subscribers had not been cleared at that point, it would enter an endless loop and throw. To avoid this, the notification stack is cleared before any of the notifiers are called. This avoids the recursive loop and the scenario no longer throws.
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps