feat: enable using design tokens in html #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
nicholasrice and
janechu
as code owners
nicholasrice
approved these changes
Nov 3, 2022
EisenbergEffect
deleted the
users/eiesnbergeffect/use-design-token-in-html
branch
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* feat: enable using design tokens in html * Change files * chore: fix change files * chore: remove unused import Co-authored-by: EisenbergEffect <roeisenb@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR implements
HTMLDirectiveonCSSDesignTokenso that it works the same in HTML as it does in CSS.🎫 Issues
👩💻 Reviewer Notes
Very simple implementation. Basically, one line of code plus registering via decorator.
📑 Test Plan
Existing tests pass. Planning to add a simple test to verify this in a follow-up PR, after the security PR is merged. I need test infrastructure from that PR to do it.
✅ Checklist
General
$ yarn change⏭ Next Steps
Follow up PR to add an HTML Directive tests.