Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first day attribute for calendar component #6398

Merged
merged 7 commits into from
Oct 10, 2022
Merged

feat: first day attribute for calendar component #6398

merged 7 commits into from
Oct 10, 2022

Conversation

robarbms
Copy link
Contributor

Pull Request

📖 Description

Some markets start the week on Monday rather than Sunday. We need a way to afford adjusting the start day.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@robarbms robarbms self-assigned this Sep 23, 2022
@robarbms robarbms linked an issue Sep 23, 2022 that may be closed by this pull request
feat: add weekday start to calendar component #6386
Closed
EisenbergEffect
EisenbergEffect approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we add some tests for this?

@robarbms robarbms merged commit dbe2989 into master Oct 10, 2022
@robarbms robarbms deleted the users/robarb/calendar-first-day branch October 10, 2022 21:23
janechu pushed a commit that referenced this pull request Jun 10, 2024
@robarbms @janechu
feat: first day attribute for calendar component (#6398)
28875d5 
* feat: calendar attr to adjust weekday start

* Change files

* nullableNumberConverter for firstDay

* api updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasrice nicholasrice nicholasrice approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@janechu janechu Awaiting requested review from janechu

Assignees

@robarbms robarbms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add weekday start to calendar component
3 participants
@robarbms @EisenbergEffect @nicholasrice